Conversation
|
This looks mostly good, apart from the giant logo. @krlmlr would it be worth for me to explore how to make the logo a PNG so it's not as huge in the pkgdown website? |
|
Please do. Thanks! |
| href: "http://hannes.muehleisen.org/" | ||
| Mark Raasveldt: | ||
| href: "https://mytherin.github.io/" | ||
|
|
There was a problem hiding this comment.
You are not listed as an author (yet?)!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 85.95% 85.89% -0.06%
==========================================
Files 106 106
Lines 3602 3602
==========================================
- Hits 3096 3094 -2
- Misses 506 508 +2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
|
So nice that there's a FAQ item on the logo http://duckdb.org/faq#where-do-i-find-the-duckdb-logo 👌 For the favicons, the logo itself would look bad so I'm using the favicon files from https://github.com/duckdb/duckdb-web/tree/main/images/favicon |
|
@krlmlr I ran |
|
Thanks! |


Fix #31
I need to build the website locally to check things, then this will be ready for review.