Skip to content

chore: Set value returned by PRAGMA user_agent to r-dbi#707

Merged
krlmlr merged 4 commits into
duckdb:mainfrom
elefeint:add_user_agent
Feb 2, 2025
Merged

chore: Set value returned by PRAGMA user_agent to r-dbi#707
krlmlr merged 4 commits into
duckdb:mainfrom
elefeint:add_user_agent

Conversation

@elefeint

Copy link
Copy Markdown
Contributor

R clients using PRAGMA user_agent historically fell back on the default "cpp" value of duckdb_api. Example output:

duckdb/v1.1.4-dev2005(linux_amd64) cpp

This PR sets an R specific r-dbi value. I used r-dbi as an analogy to jdbc, which indicates both the language and the API. Would another duckdb_api string be more appropriate?

Example output with this PR:

duckdb/v1.1.4-dev2005(linux_amd64) r-dbi

@krlmlr krlmlr changed the title Add r-dbi user-agent chore: Add r-dbi user-agent Dec 26, 2024
@krlmlr krlmlr requested a review from hannes December 26, 2024 21:17
@krlmlr krlmlr changed the title chore: Add r-dbi user-agent chore: Set value returned by PRAGMA user_agent to r-dbi Dec 26, 2024
@elefeint

Copy link
Copy Markdown
Contributor Author

@krlmlr I merged from main; could you trigger the test run when you get a chance?

@krlmlr krlmlr merged commit bd01478 into duckdb:main Feb 2, 2025
@krlmlr

krlmlr commented Feb 2, 2025

Copy link
Copy Markdown
Collaborator

Thanks!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants