Skip to content

feat: floor sub-day precision date before casting to int#981

Merged
krlmlr merged 1 commit into
duckdb:mainfrom
toppyy:date-floor
Feb 12, 2025
Merged

feat: floor sub-day precision date before casting to int#981
krlmlr merged 1 commit into
duckdb:mainfrom
toppyy:date-floor

Conversation

@toppyy
Copy link
Copy Markdown
Contributor

@toppyy toppyy commented Jan 8, 2025

Closes #517

@eitsupi
Copy link
Copy Markdown
Contributor

eitsupi commented Feb 6, 2025

@krlmlr Could you take a look at this?

@krlmlr krlmlr changed the title floor sub-day precision date before casting to int feat: floor sub-day precision date before casting to int Feb 12, 2025
@krlmlr krlmlr merged commit 9c16216 into duckdb:main Feb 12, 2025
@krlmlr
Copy link
Copy Markdown
Collaborator

krlmlr commented Feb 12, 2025

Thanks!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sub-day precision Date class must be converted to integer by floor, not trunc

3 participants