diff --git a/Makefile b/Makefile index e755b886f..c93a2b4bf 100644 --- a/Makefile +++ b/Makefile @@ -357,7 +357,7 @@ app: wasm wasmpack shell docs js_tests_release yarn workspace @duckdb/duckdb-wasm-app build:release build_loadable: - USE_GENERATED_EXPORTED_LIST=yes DUCKDB_PLATFORM=wasm_${TARGET} DUCKDB_WASM_LOADABLE_EXTENSIONS=1 GEN=ninja ./scripts/wasm_build_lib.sh relsize ${TARGET} + USE_GENERATED_EXPORTED_LIST=yes DUCKDB_PLATFORM=wasm_${TARGET} DUCKDB_WASM_LOADABLE_EXTENSIONS=1 ./scripts/wasm_build_lib.sh relsize ${TARGET} build_loadable_unsigned: build_loadable # need to propagate the unsigned flag diff --git a/lib/src/config.cc b/lib/src/config.cc index 4682d86c2..8baed3636 100644 --- a/lib/src/config.cc +++ b/lib/src/config.cc @@ -63,7 +63,7 @@ WebDBConfig WebDBConfig::ReadFrom(std::string_view args_json) { .arrow_lossless_conversion = false, .custom_user_agent = ""}; rapidjson::Document doc; - rapidjson::ParseResult ok = doc.Parse(args_json.begin(), args_json.size()); + rapidjson::ParseResult ok = doc.Parse(args_json.data(), args_json.size()); if (ok) { if (doc.HasMember("path") && doc["path"].IsString()) { config.path = doc["path"].GetString(); diff --git a/lib/src/json_parser.cc b/lib/src/json_parser.cc index 7f54a2705..bed85754e 100644 --- a/lib/src/json_parser.cc +++ b/lib/src/json_parser.cc @@ -898,7 +898,7 @@ arrow::Result> ArrayFromJSON(const std::shared_ptr std::string_view json) { rapidjson::Document json_doc; try { - json_doc.Parse(json.begin(), json.size()); + json_doc.Parse(json.data(), json.size()); } catch (...) { return arrow::Status::Invalid("invalid json document: ", json); } diff --git a/lib/src/webdb.cc b/lib/src/webdb.cc index a4e44de60..626e74678 100644 --- a/lib/src/webdb.cc +++ b/lib/src/webdb.cc @@ -354,7 +354,7 @@ arrow::Result> WebDB::Connection::Execut return arrow::Status{arrow::StatusCode::KeyError, "No prepared statement found with ID"}; rapidjson::Document args_doc; - rapidjson::ParseResult ok = args_doc.Parse(args_json.begin(), args_json.size()); + rapidjson::ParseResult ok = args_doc.Parse(args_json.data(), args_json.size()); if (!ok) return arrow::Status{arrow::StatusCode::Invalid, rapidjson::GetParseError_En(ok.Code())}; if (!args_doc.IsArray()) return arrow::Status{arrow::StatusCode::Invalid, "Arguments must be given as array"}; @@ -409,7 +409,7 @@ arrow::Status WebDB::Connection::ClosePreparedStatement(size_t statement_id) { arrow::Status WebDB::Connection::CreateScalarFunction(std::string_view def_json) { // Read the function definiton rapidjson::Document def_doc; - def_doc.Parse(def_json.begin(), def_json.size()); + def_doc.Parse(def_json.data(), def_json.size()); auto def = duckdb::make_shared_ptr(); ARROW_RETURN_NOT_OK(def->ReadFrom(def_doc)); @@ -550,7 +550,7 @@ arrow::Status WebDB::Connection::InsertArrowFromIPCStream(nonstd::span