Issue #12600: Streaming Positive LEAD #12685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 24, 2024 15:31
Implement streaming LEAD by maintaining a delay buffer. The included benchmark shows a 7x performance gain. fixes: duckdb#12600 fixes: duckdblabs/duckdb-internal#2342
Fix tidy issue with abs.
Fix another tidy issue with abs...
lnkuiper
approved these changes
Jun 25, 2024
Add test for large delta.
|
Just tried this out, and it is indeed a great improvement! |
Mytherin
reviewed
Jun 27, 2024
added 3 commits
June 27, 2024 12:20
Fix overrun error and make buffering independent of the standard vector size.
PR Feedback: * Make buffering independent of the standard vector size. * Don't allow resize during Append because it should already be the correct size.
PR Feedback: * Test with vector_size=2
added 2 commits
June 28, 2024 09:28
PR Feedback: * Avoid copying fixes: duckdb#12600 fixes: duckdblabs/duckdb-internal#2342
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 4, 2024
Merge pull request duckdb/duckdb#12685 from hawkfish/streaming-lead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement streaming LEAD by maintaining a delay buffer.
The included benchmark shows a 7x performance gain.
fixes: #12600
fixes: duckdblabs/duckdb-internal#2342