Skip to content

Line dependent buffer #14512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jan 8, 2025
Merged

Line dependent buffer #14512

merged 38 commits into from
Jan 8, 2025

Conversation

pdet
Copy link
Contributor

@pdet pdet commented Oct 23, 2024

In this PR, we modify the buffer size to be dependent on the max_line_size option.

This ensures that our buffers are always appropriately sized when max_line_size is set correctly, allowing us to read CSV files with very large lines.

Summary:

By default:

  • max_line_size: 2097152 bytes (~2MB)
  • buffer_size: 16 * max_line_size (~32MB)
  • per_thread_bytes: 4 * max_line_size (~8MB)

The buffer_size and per_thread_bytes will only be adjusted if max_line_size is set to a value larger than the default.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft October 25, 2024 11:39
@pdet pdet marked this pull request as ready for review October 25, 2024 11:48
@duckdb-draftbot duckdb-draftbot marked this pull request as draft November 4, 2024 14:21
@Mytherin Mytherin changed the base branch from feature to main November 12, 2024 09:49
@pdet pdet marked this pull request as ready for review November 29, 2024 13:53
@duckdb-draftbot duckdb-draftbot marked this pull request as draft December 2, 2024 13:48
@pdet pdet marked this pull request as ready for review December 5, 2024 10:56
@duckdb-draftbot duckdb-draftbot marked this pull request as draft December 31, 2024 11:59
@pdet pdet marked this pull request as ready for review December 31, 2024 16:29
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM - only the serialization is broken by this PR. Perhaps we can delete the old setting and add in a new one instead of changing the type?

@duckdb-draftbot duckdb-draftbot marked this pull request as draft January 2, 2025 11:21
@pdet pdet marked this pull request as ready for review January 2, 2025 11:43
@duckdb-draftbot duckdb-draftbot marked this pull request as draft January 2, 2025 18:49
@pdet pdet marked this pull request as ready for review January 2, 2025 18:49
Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One more minor comment

@duckdb-draftbot duckdb-draftbot marked this pull request as draft January 7, 2025 12:45
@pdet pdet marked this pull request as ready for review January 7, 2025 12:46
@duckdb-draftbot duckdb-draftbot marked this pull request as draft January 7, 2025 17:35
@pdet pdet marked this pull request as ready for review January 7, 2025 20:56
@Mytherin Mytherin merged commit c8fa9ae into duckdb:main Jan 8, 2025
47 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Jan 8, 2025

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jan 8, 2025
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jan 8, 2025
Line dependent buffer (duckdb/duckdb#14512)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@pdet pdet deleted the line_dependent_buffer branch January 12, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants