Support for CSV Encoding (UTF-16 and Latin-1) #14560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Thanks for the PR! LGTM - two questions:
- Could we move the decoding logic to a separate class -
EncodingFunction- that is stored in anEncodingFunctionSetin theDBConfig? Similar to theCompressionFunction. We can then do the actual decoding (and encoding?) using a few callbacks. This would then allow extensions to add new encodings. We would also need to not use an enum, but use strings as encoding names to make this work. - Could we add auto-detection for the different encodings as well? (this can also be done in a future PR if this is a lot of work)
Mytherin
reviewed
Nov 2, 2024
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 20, 2024
Support for CSV Encoding (UTF-16 and Latin-1) (duckdb/duckdb#14560)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 20, 2024
Support for CSV Encoding (UTF-16 and Latin-1) (duckdb/duckdb#14560) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
szarnyasg
added
the
Needs Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading various encodings (in addition to UTF-8) in the CSV Reader.
The mechanism should be relatively easy to extend to other encodings, as the more challenging part is handling the end-of-CSV buffers.
I'm aware of at least two discussions that have requested this feature, specifically #9783 and #9436.
From these requests, I believe we are still missing support for Shift-JIS, though implementing the mapping doesn’t seem very complicated.
I think we should centralize encoding requests in one place and tag it as a 'PRs welcome' issue, as implementing new encodings should be relatively easy (aside from the decoding method itself).