CSV Reader - 4 byte delimiters #14670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Nov 6, 2024
src/execution/operator/csv_scanner/scanner/string_value_scanner.cpp
Outdated
Show resolved
Hide resolved
src/execution/operator/csv_scanner/scanner/string_value_scanner.cpp
Outdated
Show resolved
Hide resolved
src/execution/operator/csv_scanner/scanner/string_value_scanner.cpp
Outdated
Show resolved
Hide resolved
src/execution/operator/csv_scanner/state_machine/csv_state_machine_cache.cpp
Show resolved
Hide resolved
src/include/duckdb/execution/operator/csv_scanner/state_machine_options.hpp
Outdated
Show resolved
Hide resolved
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
CSV Reader - 4 byte delimiters (duckdb/duckdb#14670) Force download doesn't require to do a head request (duckdb/duckdb#14979)
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
CSV Reader - 4 byte delimiters (duckdb/duckdb#14670) Force download doesn't require to do a head request (duckdb/duckdb#14979)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 27, 2024
CSV Reader - 4 byte delimiters (duckdb/duckdb#14670) Force download doesn't require to do a head request (duckdb/duckdb#14979) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
szarnyasg
added
the
Needs Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for delimiters of up to 4 bytes in the CSV Reader. I chose 4 bytes primarily to allow 🦆 to be used as a delimiter :-)
The parsing is implemented by adding intermediate states in the state machine to handle these specific extra bytes.
The PR includes several tests to verify that repeated character patterns (e.g., ABAC) are correctly parsed, and that multi-byte delimiters are properly handled in cases where values span multiple buffers.
I'm happy to add more tests if anyone has additional ideas for interesting edge cases to stress-test.