Build/test/distribute linux_amd64_musl core extensions #15607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
added
the
Needs Documentation
carlopi
changed the title
|
This is ready to go in. One change to be considered is skipping those tests on regular PRs, for now they are in given I wanted to have them run at least once, and possibly even a few time is a good idea. |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jan 9, 2025
Implement `simple_update` for `first` aggregate function (duckdb/duckdb#15619) Build/test/distribute linux_amd64_musl core extensions (duckdb/duckdb#15607) Improve reading duplicate column names in JSON (duckdb/duckdb#15615)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jan 9, 2025
Implement `simple_update` for `first` aggregate function (duckdb/duckdb#15619) Build/test/distribute linux_amd64_musl core extensions (duckdb/duckdb#15607) Improve reading duplicate column names in JSON (duckdb/duckdb#15615) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #15429, adding the
_musltargets to duckdb/duckdb and duckdb/extension-ci-tools#122, adding the dockerfile for building them.After this PR extensions are built, tested and distributed for an extra platform:
linux_amd64_musl.Core extensions that are not currently blocked by build-time issues are:
arrow,icebergandmysql-scanner.jemallochad also some problem building, so I removed it for now, but that should not be visible to users.There are at the moment 4 tests that fail on the musl build, I have not investigated yet why, possibly we are relying on some undefined behaviour in the libc (
muslmight do different choices fromglibcin some areas).Given the vast majory of other tests and extensions tests looks to be working, I would consider the platform as viable BUT experimental.
This also comes with the fact that this is basically untested in the wild (= by actual users).
Unconnected, but likely to generate conflicts, by I changed the names of the repositories to align to the new
duckdb-*scheme.