Repository navigation
adds BOOLEAN support to node.js bindings - #2784
Merged
Merged
Conversation
….js which verifies the support
2 tasks done
hamilton
changed the title
BOOLEAN support to node.jsBOOLEAN support to node.js bindings
Mytherin
approved these changes
Dec 13, 2021
Mytherin
left a comment
Mytherin
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Looks good to me. Will merge after the tests pass.
hannes
reviewed
Dec 13, 2021
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1342
This PR does the following:
BOOLEANsupport to the duckdb node bindings. This addition will also incidentally fix thePRAGMA table_infoproblem mentioned in the github issue above.data_type_support.test.js, which verifies the support. This test file could grow to include more comprehensive support both for existing supported data types and ones that need to be add (e.g.INTERVALas per add support forINTERVALin node.js bindings #2787)