add INTERVAL support to node.js#2819
Merged
Mytherin merged 2 commits intoduckdb:masterfrom Dec 20, 2021
Merged
Conversation
hamilton
changed the title
INTERVAL support to node.js bindingsINTERVAL support to node.js
Mytherin
approved these changes
Dec 20, 2021
Collaborator
Mytherin
left a comment
Mytherin
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2787 based on @hawkfish's suggestion. This PR:
INTERVALin node.js by converting the struct to a javascript objectApologies if my c++ is a bit elementary – I welcome feedback on the code quality.