Skip to content

** search (crawl) for files in subdirectories #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 27, 2023
Merged

** search (crawl) for files in subdirectories #6627

merged 22 commits into from
Mar 27, 2023

Conversation

lverdoes
Copy link

@lverdoes lverdoes commented Mar 8, 2023

Introduces the option to search for files in subdirectories in the local filesystem, with **

@Mytherin
Copy link
Collaborator

Mytherin commented Mar 8, 2023

Implements #5897

Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks great. Very simple implementation (which always takes the most work :)). One comment below:

@samansmink
Copy link
Contributor

samansmink commented Mar 9, 2023

@lverdoes very cool feature! I think @carlopi already talked about it with you, but we probably want to also test behaviour with symlinks. Afaik committing symlinks to git should not be an issue except for windows. An idea there is to write a test with a require notwindows which will disable the test on windows

@Mytherin
Copy link
Collaborator

@samansmink could you have another look?

Copy link
Contributor

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one more small comment, but the rest looks good :)

@Mytherin Mytherin merged commit d1518bd into duckdb:master Mar 27, 2023
@Mytherin
Copy link
Collaborator

Thanks for the work! Looks great!

@Mytherin Mytherin mentioned this pull request Mar 27, 2023
2 tasks
@Tishj Tishj mentioned this pull request May 12, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants