-
Notifications
You must be signed in to change notification settings - Fork 2.5k
** search (crawl) for files in subdirectories #6627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Implements #5897 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks great. Very simple implementation (which always takes the most work :)). One comment below:
|
@lverdoes very cool feature! I think @carlopi already talked about it with you, but we probably want to also test behaviour with symlinks. Afaik committing symlinks to git should not be an issue except for windows. An idea there is to write a test with a |
|
@samansmink could you have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one more small comment, but the rest looks good :)
|
Thanks for the work! Looks great! |
Introduces the option to search for files in subdirectories in the local filesystem, with **