ADBC - Arrow Database Connectivity - Integration #7086
Merged
+3,084
−298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sertion scan test
|
Thanks for this! On our side I'll follow up later to integrate DuckDB into our test suite somehow as well |
|
Thanks! LGTM |
|
This is exciting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the integration with ADBC, and also adds basic testing to it (Queries over dummy scans, data ingestion, queries on tables), with a testing infrastructure that internally verifies the Arrow Streams using DuckDB.
Currently, ADBC works with Linux and Mac, and tests run on both Debug CIs, Windows will come in a later PR.
I'll also extend the tests with catalog searches and more unhappy paths in the future.
CC: @lidavidm @ianmcook
Misc:
I did remove an
ADBCdefinition that seemed unused fromthird_party/libpg_query/include/utils/datetime.hppis that the case?