Issue #7809: Segment Tree Performance #7831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 3, 2023 13:13
Fix some obvious low hanging fruit with window segment trees.
Use bitwise operations to Slice ValidityMask in place when the target is aligned. Drops from 21.2s to 19.7s.
Fix case when ragged end is larger than the head.
Initialise combine buffer BEFORE it is used...
Force SliceInPlace.
Implement Vector::SliceInPlace and use for windowing.
|
That perf regression has nothing to do with the window code, and it was passing on my fork, so I think it is spurious? |
|
The performance regression is caused by #7697, and will unfortunately persist until we merge feature into master (or until we change the CI not to compare feature to master). |
carlopi
approved these changes
Jun 6, 2023
Mytherin
reviewed
Jun 6, 2023
added 2 commits
June 6, 2023 09:54
Revert Vector::SliceInPlace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case performance:
33.88632.48221.17319.43215.759