Issue #7852: Window Vectorisation #7996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hawkfish
commented
Jun 19, 2023
hawkfish
commented
- Vectorise top level functions.
- Factor WindowCustomAggregate out of WindowSegmentTree.
- Refactor WindowSegmentTree to be a subclass of WindowAggregateState.
- Move Aggregate loop into WindowAggregateState::Execute
- Fully vectorise WindowConstantAggregate to batch partition copies
- Fully vectorise segment tree computation
- Remove in-place SelectionVector use as it is now amortised
- Fix filter indexing (Another victory for vector size 2).
added 17 commits
June 11, 2023 10:29
Vectorise top level functions.
Factor WindowCustomAggregate out of WindowSegmentTree.
Refactor WindowSegmentTree to be a subclass of WindowAggregateState
Move Aggregate loop into WindowAggregateState::Execute.
Fully vectorise WindowConstantAggregate to batch partition copies.
Fully vectorise segment tree computation.
Remove in-place SelectionVector use as it is now amortised.
Fix filter indexing. (Another victory for vector size 2).
Mytherin
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.