diff --git a/app-tracking-protection/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/ui/tracker_activity/DeviceShieldActivityFeedFragment.kt b/app-tracking-protection/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/ui/tracker_activity/DeviceShieldActivityFeedFragment.kt index 6c0084c37c6d..e3d7bcbac811 100644 --- a/app-tracking-protection/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/ui/tracker_activity/DeviceShieldActivityFeedFragment.kt +++ b/app-tracking-protection/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/ui/tracker_activity/DeviceShieldActivityFeedFragment.kt @@ -22,11 +22,13 @@ import android.os.Bundle import android.view.LayoutInflater import android.view.View import android.view.ViewGroup +import androidx.core.view.get import androidx.lifecycle.Lifecycle import androidx.lifecycle.ViewModel import androidx.lifecycle.ViewModelProvider import androidx.lifecycle.flowWithLifecycle import androidx.lifecycle.lifecycleScope +import androidx.recyclerview.widget.LinearLayoutManager import com.duckduckgo.anvil.annotations.InjectWith import com.duckduckgo.app.global.DuckDuckGoFragment import com.duckduckgo.app.global.FragmentViewModelFactory @@ -44,6 +46,7 @@ import com.duckduckgo.mobile.android.vpn.ui.tracker_activity.DeviceShieldActivit import com.duckduckgo.mobile.android.vpn.ui.tracker_activity.DeviceShieldActivityFeedViewModel.Command.TrackerListDisplayed import com.duckduckgo.mobile.android.vpn.ui.tracker_activity.DeviceShieldActivityFeedViewModel.TrackerFeedViewState import com.duckduckgo.mobile.android.vpn.ui.tracker_activity.model.TrackerFeedItem +import com.google.android.material.divider.MaterialDividerItemDecoration import com.google.android.material.snackbar.Snackbar import java.util.concurrent.TimeUnit import javax.inject.Inject @@ -82,6 +85,10 @@ class DeviceShieldActivityFeedFragment : DuckDuckGoFragment() { with(binding.activityRecyclerView) { layoutManager = StickyHeadersLinearLayoutManager(this@DeviceShieldActivityFeedFragment.requireContext()) adapter = trackerFeedAdapter + val divider = MaterialDividerItemDecoration(requireActivity(), LinearLayoutManager.VERTICAL) + divider.isLastItemDecorated = false + divider.dividerInsetStart = resources.getDimensionPixelSize(R.dimen.apps_protection_state_insetPadding) + addItemDecoration(divider) } lifecycleScope.launch { diff --git a/app-tracking-protection/vpn-impl/src/main/res/layout/view_device_shield_activity_apps_protection.xml b/app-tracking-protection/vpn-impl/src/main/res/layout/view_device_shield_activity_apps_protection.xml index 4ccf2989b917..449e7585f7eb 100644 --- a/app-tracking-protection/vpn-impl/src/main/res/layout/view_device_shield_activity_apps_protection.xml +++ b/app-tracking-protection/vpn-impl/src/main/res/layout/view_device_shield_activity_apps_protection.xml @@ -26,11 +26,10 @@ android:layout_width="match_parent" android:layout_height="wrap_content" /> - + android:layout_height="@dimen/horizontalDividerHeight" + app:dividerInsetStart="@dimen/apps_protection_state_insetPadding"/> - + android:layout_marginEnd="@dimen/keyline_4" + android:drawablePadding="@dimen/keyline_4" + android:gravity="center_vertical" + android:padding="@dimen/keyline_4" + android:text="@string/atp_ActivityDescription" + app:drawableStartCompat="@drawable/ic_green_key" + app:typography="body1" /> - - - - - diff --git a/app-tracking-protection/vpn-impl/src/main/res/layout/view_device_shield_activity_entry.xml b/app-tracking-protection/vpn-impl/src/main/res/layout/view_device_shield_activity_entry.xml index a9246900e240..0fe555553060 100644 --- a/app-tracking-protection/vpn-impl/src/main/res/layout/view_device_shield_activity_entry.xml +++ b/app-tracking-protection/vpn-impl/src/main/res/layout/view_device_shield_activity_entry.xml @@ -21,7 +21,7 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="@drawable/default_selectable_bg"> + android:background="?attr/selectableItemBackground"> - - \ No newline at end of file diff --git a/app/src/main/java/com/duckduckgo/app/settings/SettingsActivity.kt b/app/src/main/java/com/duckduckgo/app/settings/SettingsActivity.kt index 6bb6ba0587bd..9d181a79f93f 100644 --- a/app/src/main/java/com/duckduckgo/app/settings/SettingsActivity.kt +++ b/app/src/main/java/com/duckduckgo/app/settings/SettingsActivity.kt @@ -163,7 +163,7 @@ class SettingsActivity : DuckDuckGoActivity() { with(viewsAppearance) { selectedThemeSetting.setClickListener { viewModel.userRequestedToChangeTheme() } - changeAppIconLabel.setClickListener { viewModel.userRequestedToChangeIcon() } + changeAppIconSetting.setOnClickListener { viewModel.userRequestedToChangeIcon() } selectedFireAnimationSetting.setClickListener { viewModel.userRequestedToChangeFireAnimation() } accessibilitySetting.setClickListener { viewModel.onAccessibilitySettingClicked() } } diff --git a/app/src/main/res/layout/activity_widget_configuration.xml b/app/src/main/res/layout/activity_widget_configuration.xml index d43cc17a89b5..f6194de6f495 100644 --- a/app/src/main/res/layout/activity_widget_configuration.xml +++ b/app/src/main/res/layout/activity_widget_configuration.xml @@ -15,6 +15,8 @@ --> @@ -22,25 +24,22 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_gravity="bottom" - android:background="@color/white" - android:padding="16dp" - android:orientation="vertical"> + android:background="?attr/daxColorSurface" + android:orientation="vertical" + android:padding="16dp"> - + android:text="@string/widgetConfigurationTitleText" + app:typography="h2" /> + tools:visibility="visible" /> + android:fontFamily="sans-serif-medium" + android:text="@string/widgetConfigurationLightThemeOption" + android:textColor="?attr/daxColorPrimaryText" /> + android:text="@string/widgetConfigurationDarkThemeOption" + android:textColor="?attr/daxColorPrimaryText" /> + android:layout_marginEnd="8dp" + android:text="@string/widgetConfigurationAddWidgetOption" /> \ No newline at end of file diff --git a/app/src/main/res/layout/content_settings_appearance.xml b/app/src/main/res/layout/content_settings_appearance.xml index 7f6a74f56bd1..13dad38ab730 100644 --- a/app/src/main/res/layout/content_settings_appearance.xml +++ b/app/src/main/res/layout/content_settings_appearance.xml @@ -41,16 +41,25 @@ app:secondaryText="@string/settingsSystemTheme" /> - + android:textColor="@color/primary_text_color_selector" + android:text="@string/changeIconCtaLabel" + app:typography="body1" /> + android:layout_height="match_parent"> + app:layout_constraintTop_toBottomOf="@id/favicon" /> - - + + \ No newline at end of file diff --git a/common-ui/src/main/res/color/red_text_color_selector.xml b/common-ui/src/main/res/color/red_text_color_selector.xml index 43e8c9737514..f4b8fd86409f 100644 --- a/common-ui/src/main/res/color/red_text_color_selector.xml +++ b/common-ui/src/main/res/color/red_text_color_selector.xml @@ -16,6 +16,6 @@ --> - - + + \ No newline at end of file diff --git a/common-ui/src/main/res/drawable/default_list_divider.xml b/common-ui/src/main/res/drawable/default_list_divider.xml deleted file mode 100644 index 147665461ffb..000000000000 --- a/common-ui/src/main/res/drawable/default_list_divider.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - - - - - - \ No newline at end of file diff --git a/common-ui/src/main/res/drawable/default_selectable_bg.xml b/common-ui/src/main/res/drawable/default_selectable_bg.xml deleted file mode 100644 index cbd1dcda9dea..000000000000 --- a/common-ui/src/main/res/drawable/default_selectable_bg.xml +++ /dev/null @@ -1,22 +0,0 @@ - - - - - \ No newline at end of file diff --git a/common-ui/src/main/res/drawable/ic_close_24_small.xml b/common-ui/src/main/res/drawable/ic_close_24_small.xml new file mode 100644 index 000000000000..0a9828442081 --- /dev/null +++ b/common-ui/src/main/res/drawable/ic_close_24_small.xml @@ -0,0 +1,26 @@ + + + + + diff --git a/common-ui/src/main/res/drawable/omnibar_field_background.xml b/common-ui/src/main/res/drawable/omnibar_field_background.xml index 6b05d05321c5..e3470f4765b2 100644 --- a/common-ui/src/main/res/drawable/omnibar_field_background.xml +++ b/common-ui/src/main/res/drawable/omnibar_field_background.xml @@ -16,8 +16,5 @@ - \ No newline at end of file diff --git a/common-ui/src/main/res/layout/include_default_toolbar.xml b/common-ui/src/main/res/layout/include_default_toolbar.xml index 82f48162802a..7a589d47bd70 100644 --- a/common-ui/src/main/res/layout/include_default_toolbar.xml +++ b/common-ui/src/main/res/layout/include_default_toolbar.xml @@ -17,13 +17,11 @@ ~ limitations under the License. --> - + app:popupTheme="@style/Widget.DuckDuckGo.PopUpOverflowMenu" /> diff --git a/common-ui/src/main/res/values/attrs.xml b/common-ui/src/main/res/values/attrs.xml index bb58bf00539a..0a084b84c367 100644 --- a/common-ui/src/main/res/values/attrs.xml +++ b/common-ui/src/main/res/values/attrs.xml @@ -38,7 +38,6 @@ - diff --git a/common-ui/src/main/res/values/design-system-colors.xml b/common-ui/src/main/res/values/design-system-colors.xml index b98b50d69287..b3be5ec4c750 100644 --- a/common-ui/src/main/res/values/design-system-colors.xml +++ b/common-ui/src/main/res/values/design-system-colors.xml @@ -150,6 +150,7 @@ #35000000 #2E000000 #1F000000 + #17000000 #0F000000 #08000000 #000000 diff --git a/common-ui/src/main/res/values/design-system-dimensions.xml b/common-ui/src/main/res/values/design-system-dimensions.xml index 7b6031480a5c..9fa5b2f185af 100644 --- a/common-ui/src/main/res/values/design-system-dimensions.xml +++ b/common-ui/src/main/res/values/design-system-dimensions.xml @@ -99,7 +99,7 @@ 20dp - 14dp + 10dp 22dp diff --git a/common-ui/src/main/res/values/design-system-theming.xml b/common-ui/src/main/res/values/design-system-theming.xml index 8e47daf24302..20c4c202f1bd 100644 --- a/common-ui/src/main/res/values/design-system-theming.xml +++ b/common-ui/src/main/res/values/design-system-theming.xml @@ -81,6 +81,7 @@ @style/Widget.DuckDuckGo.DaxButton.Secondary @style/Widget.DuckDuckGo.DaxButton.Ghost @style/Widget.DuckDuckGo.CardView + @style/Widget.DuckDuckGo.ListDivider @style/Widget.DuckDuckGo.DaxButton.TextButton.Primary @@ -223,7 +224,6 @@ @color/cornflowerBlue ?attr/dialogBgColor - @color/gray80 @null @color/darkThemePrimaryDark @@ -239,6 +239,7 @@ @color/gray0 @color/gray90 @color/white12 + @color/gray85 @color/white84 @color/black84 @color/white60 @@ -252,7 +253,6 @@ @color/blue30 @color/yellow50 @color/white12 - @color/gray85 @@ -363,7 +363,6 @@ @color/cornflowerBlue ?attr/dialogBgColor - @color/gray30 @drawable/divider_shadow_background @color/tooltipPanelBackgroundColorLight @@ -379,6 +378,7 @@ @color/gray100 @color/white @color/black6 + @color/white @color/black84 @color/white84 @color/black60 @@ -388,11 +388,10 @@ @color/alertRedOnLightDefault @color/black6 @color/black36 - @color/black18 + @color/black9 @color/blue50 @color/yellow50 @color/black6 - @color/white diff --git a/common-ui/src/main/res/values/widgets.xml b/common-ui/src/main/res/values/widgets.xml index 219d1dbef069..20540f163dd2 100644 --- a/common-ui/src/main/res/values/widgets.xml +++ b/common-ui/src/main/res/values/widgets.xml @@ -26,11 +26,11 @@ + + @@ -450,4 +455,5 @@ ?attr/daxColorSurface @style/ShapeAppearance.DuckDuckGo.MediumComponent + \ No newline at end of file