From 8abbf71eccec5dfa6518ec2f59d89ea429ee20e4 Mon Sep 17 00:00:00 2001 From: Cristian Monforte Date: Wed, 10 Mar 2021 13:41:31 +0100 Subject: [PATCH] avoid keeping reference to dialog instance --- .../main/java/com/duckduckgo/app/browser/BrowserActivity.kt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt b/app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt index c1dc7e50da22..a6e704dec3ed 100644 --- a/app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt +++ b/app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt @@ -92,8 +92,6 @@ class BrowserActivity : DuckDuckGoActivity(), CoroutineScope by MainScope() { private var lastIntent: Intent? = null - private var currentAppEnjoymentFragment: DialogFragment? = null - private lateinit var renderer: BrowserStateRenderer private var openMessageInNewTabJob: Job? = null @@ -433,9 +431,8 @@ class BrowserActivity : DuckDuckGoActivity(), CoroutineScope by MainScope() { get() = (flags and Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY) == Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY private fun showAppEnjoymentPrompt(prompt: DialogFragment) { - currentAppEnjoymentFragment?.dismiss() + (supportFragmentManager.findFragmentByTag(APP_ENJOYMENT_DIALOG_TAG) as? DialogFragment)?.dismiss() prompt.show(supportFragmentManager, APP_ENJOYMENT_DIALOG_TAG) - currentAppEnjoymentFragment = prompt } private fun hideWebContent() {