From a1b544628a15bf2e07316ed96e522bfd5459affc Mon Sep 17 00:00:00 2001 From: Marcos Holgado Date: Fri, 23 Apr 2021 13:52:38 +0100 Subject: [PATCH] Disable serp variants --- .../java/com/duckduckgo/app/statistics/VariantManagerTest.kt | 4 ++-- .../main/java/com/duckduckgo/app/statistics/VariantManager.kt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt b/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt index 80ea9432bb80..40b0b0b7e68d 100644 --- a/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt +++ b/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt @@ -32,14 +32,14 @@ class VariantManagerTest { @Test fun serpControlVariantHasExpectedWeightAndNoFeatures() { val variant = variants.first { it.key == "sc" } - assertEqualsDouble(1.0, variant.weight) + assertEqualsDouble(0.0, variant.weight) assertEquals(0, variant.features.size) } @Test fun serpExperimentalVariantHasExpectedWeightAndNoFeatures() { val variant = variants.first { it.key == "se" } - assertEqualsDouble(1.0, variant.weight) + assertEqualsDouble(0.0, variant.weight) assertEquals(0, variant.features.size) } diff --git a/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt b/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt index d6803c7e1b5f..8d2a8f0a019b 100644 --- a/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt +++ b/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt @@ -43,8 +43,8 @@ interface VariantManager { val ACTIVE_VARIANTS = listOf( // SERP variants. "sc" may also be used as a shared control for mobile experiments in // the future if we can filter by app version - Variant(key = "sc", weight = 1.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), - Variant(key = "se", weight = 1.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), + Variant(key = "sc", weight = 0.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), + Variant(key = "se", weight = 0.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), // InAppUsage Experiments Variant(key = "ma", weight = 1.0, features = emptyList(), filterBy = { isEnglishLocale() }),