Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate autofill repo #1229

Merged
merged 2 commits into from May 10, 2021
Merged

Conversation

marcosholgado
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1198964220583541/1200222336221930
Tech Design URL:
CC:

Description:
This PR adds the autofill repo as a submodule rather than hardcoding it

Steps to test this PR:
Steps in https://app.asana.com/0/1198964220583541/1200222336221930


Internal references:

Software Engineering Expectations
Technical Design Template

@aitorvs aitorvs self-assigned this May 10, 2021
Copy link
Collaborator

@aitorvs aitorvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

val js = InstrumentationRegistry.getInstrumentation().targetContext.resources.openRawResource(R.raw.autofill)
.bufferedReader()
.use { it.readText() }
val js = readResource().use { it?.readText() }.orEmpty()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use for the win

@marcosholgado marcosholgado merged commit dcd5b5e into develop May 10, 2021
@marcosholgado marcosholgado deleted the feature/marcos/add_autofill_repo branch May 10, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants