From f01bddd8859fa72fdf7b2defa95ac7a82016c29b Mon Sep 17 00:00:00 2001 From: Marcos Holgado Date: Thu, 20 May 2021 07:36:04 +0100 Subject: [PATCH] Enable serp variants --- .../com/duckduckgo/app/statistics/VariantManagerTest.kt | 8 ++++---- .../java/com/duckduckgo/app/statistics/VariantManager.kt | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt b/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt index 11e50781d205..406a69167837 100644 --- a/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt +++ b/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt @@ -32,14 +32,14 @@ class VariantManagerTest { @Test fun serpControlVariantHasExpectedWeightAndNoFeatures() { val variant = variants.first { it.key == "sc" } - assertEqualsDouble(0.0, variant.weight) + assertEqualsDouble(1.0, variant.weight) assertEquals(0, variant.features.size) } @Test fun serpExperimentalVariantHasExpectedWeightAndNoFeatures() { val variant = variants.first { it.key == "se" } - assertEqualsDouble(0.0, variant.weight) + assertEqualsDouble(1.0, variant.weight) assertEquals(0, variant.features.size) } @@ -73,14 +73,14 @@ class VariantManagerTest { @Test fun newInBrowserControlVariantHasExpectedWeightAndNoFeatures() { val variant = variants.first { it.key == "zx" } - assertEqualsDouble(1.0, variant.weight) + assertEqualsDouble(0.0, variant.weight) assertEquals(0, variant.features.size) } @Test fun newInBrowserInAppUsageVariantHasExpectedWeightAndKillOnboardingAndInAppUsageFeatures() { val variant = variants.first { it.key == "zy" } - assertEqualsDouble(1.0, variant.weight) + assertEqualsDouble(0.0, variant.weight) assertEquals(2, variant.features.size) assertTrue(variant.hasFeature(KillOnboarding)) assertTrue(variant.hasFeature(InAppUsage)) diff --git a/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt b/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt index 29a6d040e41b..f69b73637d38 100644 --- a/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt +++ b/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt @@ -43,16 +43,16 @@ interface VariantManager { val ACTIVE_VARIANTS = listOf( // SERP variants. "sc" may also be used as a shared control for mobile experiments in // the future if we can filter by app version - Variant(key = "sc", weight = 0.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), - Variant(key = "se", weight = 0.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), + Variant(key = "sc", weight = 1.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), + Variant(key = "se", weight = 1.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), // InAppUsage Experiments Variant(key = "ma", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }), Variant(key = "mb", weight = 0.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.RemoveDay1AndDay3Notifications), filterBy = { isEnglishLocale() }), Variant(key = "mc", weight = 0.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.InAppUsage, VariantFeature.RemoveDay1AndDay3Notifications), filterBy = { isEnglishLocale() }), - Variant(key = "zx", weight = 1.0, features = emptyList(), filterBy = { isEnglishLocale() }), - Variant(key = "zy", weight = 1.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.InAppUsage), filterBy = { isEnglishLocale() }) + Variant(key = "zx", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }), + Variant(key = "zy", weight = 0.0, features = listOf(VariantFeature.KillOnboarding, VariantFeature.InAppUsage), filterBy = { isEnglishLocale() }) ) val REFERRER_VARIANTS = listOf(