From 5562d25764672abf73aa2eecf42c6c7ac7bf2915 Mon Sep 17 00:00:00 2001 From: Marcos Holgado Date: Mon, 24 May 2021 13:04:29 +0100 Subject: [PATCH] Remove SERP variants --- .../java/com/duckduckgo/app/statistics/VariantManagerTest.kt | 4 ++-- .../main/java/com/duckduckgo/app/statistics/VariantManager.kt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt b/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt index 406a69167837..5f0603d9b481 100644 --- a/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt +++ b/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt @@ -32,14 +32,14 @@ class VariantManagerTest { @Test fun serpControlVariantHasExpectedWeightAndNoFeatures() { val variant = variants.first { it.key == "sc" } - assertEqualsDouble(1.0, variant.weight) + assertEqualsDouble(0.0, variant.weight) assertEquals(0, variant.features.size) } @Test fun serpExperimentalVariantHasExpectedWeightAndNoFeatures() { val variant = variants.first { it.key == "se" } - assertEqualsDouble(1.0, variant.weight) + assertEqualsDouble(0.0, variant.weight) assertEquals(0, variant.features.size) } diff --git a/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt b/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt index f69b73637d38..49b9b68183ad 100644 --- a/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt +++ b/statistics/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt @@ -43,8 +43,8 @@ interface VariantManager { val ACTIVE_VARIANTS = listOf( // SERP variants. "sc" may also be used as a shared control for mobile experiments in // the future if we can filter by app version - Variant(key = "sc", weight = 1.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), - Variant(key = "se", weight = 1.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), + Variant(key = "sc", weight = 0.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), + Variant(key = "se", weight = 0.0, features = emptyList(), filterBy = { isSerpRegionToggleCountry() }), // InAppUsage Experiments Variant(key = "ma", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }),