From 7f31bb792db979e0a450ce9f86937c0eadf97cfc Mon Sep 17 00:00:00 2001 From: Aitor Viana Date: Wed, 4 Aug 2021 11:04:39 +0200 Subject: [PATCH] [BUG] Fix crash when accidentally returning binding.root in onCreateView --- .../MainReasonNegativeFeedbackFragment.kt | 13 +++---------- .../subreason/SubReasonNegativeFeedbackFragment.kt | 13 +++---------- 2 files changed, 6 insertions(+), 20 deletions(-) diff --git a/app/src/main/java/com/duckduckgo/app/feedback/ui/negative/mainreason/MainReasonNegativeFeedbackFragment.kt b/app/src/main/java/com/duckduckgo/app/feedback/ui/negative/mainreason/MainReasonNegativeFeedbackFragment.kt index cab451ec2a70..e9512d8c8d5b 100644 --- a/app/src/main/java/com/duckduckgo/app/feedback/ui/negative/mainreason/MainReasonNegativeFeedbackFragment.kt +++ b/app/src/main/java/com/duckduckgo/app/feedback/ui/negative/mainreason/MainReasonNegativeFeedbackFragment.kt @@ -17,9 +17,6 @@ package com.duckduckgo.app.feedback.ui.negative.mainreason import android.os.Bundle -import android.view.LayoutInflater -import android.view.View -import android.view.ViewGroup import androidx.core.content.ContextCompat import androidx.recyclerview.widget.LinearLayoutManager import com.duckduckgo.app.browser.R @@ -44,19 +41,15 @@ class MainReasonNegativeFeedbackFragment : FeedbackFragment(R.layout.content_fee private val listener: MainReasonNegativeFeedbackListener? get() = activity as MainReasonNegativeFeedbackListener - override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? { + override fun onActivityCreated(savedInstanceState: Bundle?) { + super.onActivityCreated(savedInstanceState) + recyclerAdapter = MainReasonAdapter(object : (FeedbackTypeMainReasonDisplay) -> Unit { override fun invoke(reason: FeedbackTypeMainReasonDisplay) { listener?.userSelectedNegativeFeedbackMainReason(reason.mainReason) } }) - return binding.root - } - - override fun onActivityCreated(savedInstanceState: Bundle?) { - super.onActivityCreated(savedInstanceState) - activity?.let { binding.recyclerView.layoutManager = LinearLayoutManager(it) binding.recyclerView.adapter = recyclerAdapter diff --git a/app/src/main/java/com/duckduckgo/app/feedback/ui/negative/subreason/SubReasonNegativeFeedbackFragment.kt b/app/src/main/java/com/duckduckgo/app/feedback/ui/negative/subreason/SubReasonNegativeFeedbackFragment.kt index eda73ce4c942..8eba063fd049 100644 --- a/app/src/main/java/com/duckduckgo/app/feedback/ui/negative/subreason/SubReasonNegativeFeedbackFragment.kt +++ b/app/src/main/java/com/duckduckgo/app/feedback/ui/negative/subreason/SubReasonNegativeFeedbackFragment.kt @@ -17,9 +17,6 @@ package com.duckduckgo.app.feedback.ui.negative.subreason import android.os.Bundle -import android.view.LayoutInflater -import android.view.View -import android.view.ViewGroup import androidx.core.content.ContextCompat import androidx.recyclerview.widget.LinearLayoutManager import com.duckduckgo.app.browser.R @@ -52,7 +49,9 @@ class SubReasonNegativeFeedbackFragment : FeedbackFragment(R.layout.content_feed private lateinit var mainReason: MainReason - override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? { + override fun onActivityCreated(savedInstanceState: Bundle?) { + super.onActivityCreated(savedInstanceState) + recyclerAdapter = SubReasonAdapter(object : (FeedbackTypeSubReasonDisplay) -> Unit { override fun invoke(reason: FeedbackTypeSubReasonDisplay) { when (reason.subReason) { @@ -72,12 +71,6 @@ class SubReasonNegativeFeedbackFragment : FeedbackFragment(R.layout.content_feed } }) - return binding.root - } - - override fun onActivityCreated(savedInstanceState: Bundle?) { - super.onActivityCreated(savedInstanceState) - activity?.let { binding.recyclerView.layoutManager = LinearLayoutManager(it) binding.recyclerView.adapter = recyclerAdapter