diff --git a/app/src/androidTest/java/com/duckduckgo/app/statistics/ExperimentationVariantManagerTest.kt b/app/src/androidTest/java/com/duckduckgo/app/statistics/ExperimentationVariantManagerTest.kt index f4329fa6bb85..3672474a33c8 100644 --- a/app/src/androidTest/java/com/duckduckgo/app/statistics/ExperimentationVariantManagerTest.kt +++ b/app/src/androidTest/java/com/duckduckgo/app/statistics/ExperimentationVariantManagerTest.kt @@ -16,8 +16,6 @@ package com.duckduckgo.app.statistics -import android.os.Build -import android.support.test.filters.SdkSuppress import com.duckduckgo.app.statistics.store.StatisticsDataStore import com.nhaarman.mockito_kotlin.* import org.junit.Assert.assertEquals @@ -95,8 +93,7 @@ class ExperimentationVariantManagerTest { @Test - @SdkSuppress(minSdkVersion = Build.VERSION_CODES.N) - fun whenNougatOrLaterAndNoVariantPersistedThenNewVariantAllocated() { + fun whenNoVariantPersistedThenNewVariantAllocated() { activeVariants.add(Variant("foo", 100.0)) testee.getVariant(activeVariants) @@ -105,30 +102,11 @@ class ExperimentationVariantManagerTest { } @Test - @SdkSuppress(minSdkVersion = Build.VERSION_CODES.N) - fun whenNougatOrLaterAndNoVariantPersistedThenNewVariantKeyIsAllocatedAndPersisted() { + fun whenNoVariantPersistedThenNewVariantKeyIsAllocatedAndPersisted() { activeVariants.add(Variant("foo", 100.0)) testee.getVariant(activeVariants) verify(mockStore).variant = "foo" } - - @Test - @SdkSuppress(maxSdkVersion = Build.VERSION_CODES.M) - fun whenMarshmallowOrEarlierAndNoVariantPersistedThenDefaultVariantAllocated() { - activeVariants.add(Variant("foo", 100.0)) - - assertEquals(VariantManager.DEFAULT_VARIANT, testee.getVariant(activeVariants)) - } - - @Test - @SdkSuppress(maxSdkVersion = Build.VERSION_CODES.M) - fun whenMarshmallowOrEarlierAndNoVariantPersistedThenDefaultVariantKeyIsAllocatedAndPersisted() { - activeVariants.add(Variant("foo", 100.0)) - - testee.getVariant(activeVariants) - - verify(mockStore).variant = VariantManager.DEFAULT_VARIANT.key - } } \ No newline at end of file diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 8ceee34a5740..d77c75510fd8 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -15,7 +15,7 @@ android:label="@string/appName" android:networkSecurityConfig="@xml/network_security_config" android:supportsRtl="true" - android:theme="@style/AppTheme.Dark" + android:theme="@style/AppTheme" tools:ignore="GoogleAppIndexingWarning"> - @@ -116,8 +115,7 @@ android:theme="@style/ModalCardTheme" /> + android:process="@string/fireProcessName" /> R.style.AppTheme_Light - DuckDuckGoTheme.DARK -> R.style.AppTheme_Dark - } -} - -private fun DuckDuckGoActivity.isThemeConfigurable(): Boolean { - return manifestThemeId() == R.style.AppTheme_Dark || manifestThemeId() == R.style.AppTheme_Light -} - private fun DuckDuckGoActivity.manifestThemeId(): Int { return packageManager.getActivityInfo(componentName, 0).themeResource } - -private fun defaultApplicationTheme(variant: Variant): DuckDuckGoTheme { - return if (variant.hasFeature(LightThemeAsDefault)) DuckDuckGoTheme.LIGHT else DuckDuckGoTheme.DARK -} - -object ThemingConstants { - const val BROADCAST_THEME_CHANGED = "BROADCAST_THEME_CHANGED" -} diff --git a/app/src/main/java/com/duckduckgo/app/httpsupgrade/api/HttpsUpgradeDataDownloader.kt b/app/src/main/java/com/duckduckgo/app/httpsupgrade/api/HttpsUpgradeDataDownloader.kt index 1026828a5b37..587d9270910c 100644 --- a/app/src/main/java/com/duckduckgo/app/httpsupgrade/api/HttpsUpgradeDataDownloader.kt +++ b/app/src/main/java/com/duckduckgo/app/httpsupgrade/api/HttpsUpgradeDataDownloader.kt @@ -122,7 +122,7 @@ class HttpsUpgradeDataDownloader @Inject constructor( return@defer complete() } val params = mapOf( - APP_VERSION to "${BuildConfig.VERSION_NAME}", + APP_VERSION to BuildConfig.VERSION_NAME, TOTAL_COUNT to statisticsDataStore.httpsUpgradesTotal.toString(), FAILURE_COUNT to statisticsDataStore.httpsUpgradesFailures.toString() ) diff --git a/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt b/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt index 8426670dec53..9d457329f9bd 100644 --- a/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt +++ b/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt @@ -96,14 +96,8 @@ class ExperimentationVariantManager( } private fun generateVariant(activeVariants: List): Variant { - if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.M) { - Timber.i("No variants available for pre-Nougat devices") - return DEFAULT_VARIANT - } - val randomizedIndex = indexRandomizer.random(activeVariants) return activeVariants[randomizedIndex] - } } diff --git a/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherAdapter.kt b/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherAdapter.kt index aab2497d0f9e..3bf1e74b0ffc 100644 --- a/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherAdapter.kt +++ b/app/src/main/java/com/duckduckgo/app/tabs/ui/TabSwitcherAdapter.kt @@ -53,7 +53,6 @@ class TabSwitcherAdapter(private val context: Context, private val itemClickList holder.url.text = tab.displayUrl() holder.tabUnread.visibility = if (tab.viewed) View.INVISIBLE else View.VISIBLE holder.root.setBackgroundResource(if (tab.tabId == selectedTab?.tabId) SELECTED_BACKGROUND else DEFAULT_BACKGROUND) - holder.root.alpha = if (tab.tabId == selectedTab?.tabId) SELECTED_ALPHA else DEFAULT_ALPHA GlideApp.with(holder.root) .load(tab.favicon()) @@ -103,10 +102,6 @@ class TabSwitcherAdapter(private val context: Context, private val itemClickList private const val SELECTED_BACKGROUND = R.drawable.tab_background_selected @DrawableRes private const val DEFAULT_BACKGROUND = R.drawable.tab_background - - private const val SELECTED_ALPHA = 1.0f - private const val DEFAULT_ALPHA = 0.77f - } } diff --git a/app/src/main/res/drawable/tab_background_selected.xml b/app/src/main/res/drawable/tab_background_selected.xml index 760b0cca715b..a1f342e86319 100644 --- a/app/src/main/res/drawable/tab_background_selected.xml +++ b/app/src/main/res/drawable/tab_background_selected.xml @@ -18,6 +18,6 @@ + android:color="?attr/tabSelectedBorderColor" /> \ No newline at end of file diff --git a/app/src/main/res/drawable/tab_unread.xml b/app/src/main/res/drawable/tab_unread.xml index 00ee84d331ce..d571ed4fc9d4 100644 --- a/app/src/main/res/drawable/tab_unread.xml +++ b/app/src/main/res/drawable/tab_unread.xml @@ -18,5 +18,5 @@ - + diff --git a/app/src/main/res/layout/activity_tab_switcher.xml b/app/src/main/res/layout/activity_tab_switcher.xml index 5352f1493f69..b73cf32f9b86 100644 --- a/app/src/main/res/layout/activity_tab_switcher.xml +++ b/app/src/main/res/layout/activity_tab_switcher.xml @@ -18,7 +18,6 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="match_parent" - android:background="?attr/tabsBackgroundColor" tools:context="com.duckduckgo.app.tabs.ui.TabSwitcherActivity"> diff --git a/app/src/main/res/layout/content_tab_switcher.xml b/app/src/main/res/layout/content_tab_switcher.xml index f8069a1e25fe..22a5128642e6 100644 --- a/app/src/main/res/layout/content_tab_switcher.xml +++ b/app/src/main/res/layout/content_tab_switcher.xml @@ -32,6 +32,8 @@ android:id="@+id/tabsRecycler" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginTop="5dp" + android:layout_marginBottom="5dp" tools:itemCount="3" tools:listitem="@layout/item_tab" /> @@ -47,7 +49,7 @@ android:layout_height="wrap_content" android:fontFamily="sans-serif" android:text="@string/tapFireDirective" - android:textColor="@color/white" + android:textColor="?attr/tabsFireTextColor" android:textSize="14sp" android:textStyle="normal" /> @@ -58,14 +60,14 @@ android:layout_marginEnd="6dp" android:contentDescription="@string/tapFireIconDescription" android:src="@drawable/ic_fire_24dp" - android:tint="@color/white" /> + android:tint="?attr/tabsFireTextColor" /> diff --git a/app/src/main/res/layout/include_omnibar_toolbar.xml b/app/src/main/res/layout/include_omnibar_toolbar.xml index 534c270e574f..dcc57e3ad9ba 100644 --- a/app/src/main/res/layout/include_omnibar_toolbar.xml +++ b/app/src/main/res/layout/include_omnibar_toolbar.xml @@ -39,6 +39,7 @@ android:layout_width="0dp" android:layout_height="?attr/actionBarSize" android:background="?attr/colorPrimary" + android:theme="@style/OmnibarToolbarTheme" app:contentInsetEnd="0dp" app:contentInsetStart="0dp" app:layout_constraintBottom_toBottomOf="parent" diff --git a/app/src/main/res/layout/include_toolbar.xml b/app/src/main/res/layout/include_toolbar.xml index f65459db4c57..153ffcbe1118 100644 --- a/app/src/main/res/layout/include_toolbar.xml +++ b/app/src/main/res/layout/include_toolbar.xml @@ -29,7 +29,6 @@ android:id="@+id/toolbar" android:layout_width="match_parent" android:layout_height="?attr/actionBarSize" - android:background="?attr/colorPrimary" android:theme="@style/ToolbarTheme" app:popupTheme="@style/AppTheme.Dark.PopupOverlay" /> diff --git a/app/src/main/res/layout/item_tab.xml b/app/src/main/res/layout/item_tab.xml index 84986447fc55..99696dbbff74 100644 --- a/app/src/main/res/layout/item_tab.xml +++ b/app/src/main/res/layout/item_tab.xml @@ -20,9 +20,11 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="10dp" - android:layout_marginTop="10dp" + android:layout_marginTop="5dp" android:layout_marginEnd="10dp" - android:background="@drawable/tab_background"> + android:layout_marginBottom="5dp" + android:background="@drawable/tab_background" + android:elevation="2dp"> - + + + diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 965771998e15..d214dba77574 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -127,7 +127,7 @@ - - + +