From be90dd815728e3406c2b1982a7bd3d7bf4be90ed Mon Sep 17 00:00:00 2001 From: Mike Scamell Date: Fri, 9 Aug 2024 15:13:31 +0100 Subject: [PATCH 1/4] Add splashscreen compat dependency --- common/common-ui/build.gradle | 1 + versions.properties | 2 ++ 2 files changed, 3 insertions(+) diff --git a/common/common-ui/build.gradle b/common/common-ui/build.gradle index 9e9c93a111a4..bf36030e672c 100644 --- a/common/common-ui/build.gradle +++ b/common/common-ui/build.gradle @@ -46,6 +46,7 @@ dependencies { implementation AndroidX.appCompat implementation Google.android.material implementation AndroidX.constraintLayout + implementation AndroidX.core.splashscreen implementation AndroidX.recyclerView implementation AndroidX.lifecycle.viewModelKtx // just to get the dagger annotations diff --git a/versions.properties b/versions.properties index a14655bf0d7b..e92796a4e0d6 100644 --- a/versions.properties +++ b/versions.properties @@ -19,6 +19,8 @@ version.androidx.constraintlayout=2.1.4 version.androidx.biometric=1.1.0 +version.androidx.core-splashscreen=1.0.1 + version.androidx.datastore=1.1.1 version.androidx.localbroadcastmanager=1.1.0 From ce9a57cab43f0bea395bd7dfad474c408f63fcaa Mon Sep 17 00:00:00 2001 From: Mike Scamell Date: Fri, 9 Aug 2024 15:40:39 +0100 Subject: [PATCH 2/4] Remove splashscreen styles in v31 files The compat library will take care of this for us so we put everything in the root values files which is the next commit. --- .../design-system-theming.xml | 23 --------------- .../res/values-v31/design-system-theming.xml | 28 ------------------- 2 files changed, 51 deletions(-) delete mode 100644 common/common-ui/src/main/res/values-night-v31/design-system-theming.xml delete mode 100644 common/common-ui/src/main/res/values-v31/design-system-theming.xml diff --git a/common/common-ui/src/main/res/values-night-v31/design-system-theming.xml b/common/common-ui/src/main/res/values-night-v31/design-system-theming.xml deleted file mode 100644 index ccb65956918b..000000000000 --- a/common/common-ui/src/main/res/values-night-v31/design-system-theming.xml +++ /dev/null @@ -1,23 +0,0 @@ - - - - - diff --git a/common/common-ui/src/main/res/values-v31/design-system-theming.xml b/common/common-ui/src/main/res/values-v31/design-system-theming.xml deleted file mode 100644 index 09fbc2b87231..000000000000 --- a/common/common-ui/src/main/res/values-v31/design-system-theming.xml +++ /dev/null @@ -1,28 +0,0 @@ - - - - - From bb32f4bb9874f45e00be47bb738cdca99bdd55fd Mon Sep 17 00:00:00 2001 From: Mike Scamell Date: Fri, 9 Aug 2024 15:43:35 +0100 Subject: [PATCH 3/4] Add new splashscreen style As we're not inheriting from any theme we'll need to set the colors for the status bar and navigation bar in the splash style. I'm using what I found on the light and dark themes. --- .../main/res/values-night/design-system-theming.xml | 9 ++++++++- .../src/main/res/values/design-system-theming.xml | 13 ++++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/common/common-ui/src/main/res/values-night/design-system-theming.xml b/common/common-ui/src/main/res/values-night/design-system-theming.xml index 5be4428aeddb..4350821f20d8 100644 --- a/common/common-ui/src/main/res/values-night/design-system-theming.xml +++ b/common/common-ui/src/main/res/values-night/design-system-theming.xml @@ -15,5 +15,12 @@ --> - diff --git a/common/common-ui/src/main/res/values/design-system-theming.xml b/common/common-ui/src/main/res/values/design-system-theming.xml index de8a74c80137..766b83126357 100644 --- a/common/common-ui/src/main/res/values/design-system-theming.xml +++ b/common/common-ui/src/main/res/values/design-system-theming.xml @@ -296,7 +296,18 @@ @color/white - + +