From 2f65fab0f676d7e11ad6d750575bb67e189e06db Mon Sep 17 00:00:00 2001 From: Craig Russell Date: Mon, 27 May 2019 14:58:45 +0100 Subject: [PATCH 1/3] Code tidy --- .../com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt b/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt index 9f4c8d32f0dd..4c31e33fb719 100644 --- a/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt +++ b/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt @@ -46,7 +46,6 @@ class OnboardingViewModel( fun onOnboardingDone() { onboardingStore.onboardingShown() fireTrackerBlockingFinalStatePixel() - } private fun fireTrackerBlockingFinalStatePixel() { @@ -59,4 +58,4 @@ class OnboardingViewModel( pixel.fire(pixelName) } } -} +} \ No newline at end of file From 871eff44f3fdcbf46e41b18cd1143bf77135a5cb Mon Sep 17 00:00:00 2001 From: Craig Russell Date: Mon, 27 May 2019 14:59:37 +0100 Subject: [PATCH 2/3] Remove experimental variant for tracker blocker opt-in --- .../java/com/duckduckgo/app/statistics/VariantManager.kt | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt b/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt index b42248130262..1f00c99a58d4 100644 --- a/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt +++ b/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt @@ -50,11 +50,7 @@ interface VariantManager { Variant(key = "me", weight = 0.0, features = listOf(NotificationPrivacyDay1, NotificationSuppressClearDataDay3)), Variant(key = "mi", weight = 0.0, features = listOf(NotificationClearDataDay1, NotificationSuppressClearDataDay3)), Variant(key = "mf", weight = 0.0, features = listOf(NotificationSuppressClearDataDay3)), - Variant(key = "mk", weight = 0.0, features = listOf(NotificationPrivacyDay1)), - - // tracker blocker opt in variants - Variant(key = "mm", weight = 1.0, features = emptyList()), - Variant(key = "mn", weight = 1.0, features = listOf(TrackerBlockingOnboardingOptIn)) + Variant(key = "mk", weight = 0.0, features = listOf(NotificationPrivacyDay1)) ) } From 69a4b1844f503b90321440246556601903c32cbf Mon Sep 17 00:00:00 2001 From: Craig Russell Date: Mon, 27 May 2019 17:03:58 +0100 Subject: [PATCH 3/3] Restore tracker blocker opt-in experiments with 0-weighting --- .../java/com/duckduckgo/app/statistics/VariantManager.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt b/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt index 1f00c99a58d4..4913629d9ee1 100644 --- a/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt +++ b/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt @@ -50,7 +50,11 @@ interface VariantManager { Variant(key = "me", weight = 0.0, features = listOf(NotificationPrivacyDay1, NotificationSuppressClearDataDay3)), Variant(key = "mi", weight = 0.0, features = listOf(NotificationClearDataDay1, NotificationSuppressClearDataDay3)), Variant(key = "mf", weight = 0.0, features = listOf(NotificationSuppressClearDataDay3)), - Variant(key = "mk", weight = 0.0, features = listOf(NotificationPrivacyDay1)) + Variant(key = "mk", weight = 0.0, features = listOf(NotificationPrivacyDay1)), + + // tracker blocker opt in variants + Variant(key = "mm", weight = 0.0, features = emptyList()), + Variant(key = "mn", weight = 0.0, features = listOf(TrackerBlockingOnboardingOptIn)) ) } @@ -100,6 +104,7 @@ class ExperimentationVariantManager( private fun generateVariant(activeVariants: List): Variant { val weightSum = activeVariants.sumByDouble { it.weight } if (weightSum == 0.0) { + Timber.v("No variants active; allocating default") return DEFAULT_VARIANT } val randomizedIndex = indexRandomizer.random(activeVariants)