From fdacda8aad9a7af25bc87aea9208075a831b8d05 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Gonz=C3=A1lez?= Date: Thu, 23 Oct 2025 13:13:33 +0200 Subject: [PATCH 1/2] Fix JS selector --- .../com/duckduckgo/duckchat/impl/helper/DuckChatJSHelper.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/helper/DuckChatJSHelper.kt b/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/helper/DuckChatJSHelper.kt index 50e987142e2f..d35ce0c3318f 100644 --- a/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/helper/DuckChatJSHelper.kt +++ b/duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/helper/DuckChatJSHelper.kt @@ -152,7 +152,7 @@ class RealDuckChatJSHelper @Inject constructor( ): JsCallbackData { val jsonPayload = JSONObject().apply { - val jsCall = "document.getElementsByName($selector)[0]?.focus();" + val jsCall = "document.getElementsByName('$selector')[0]?.focus();" put(SELECTOR, jsCall) put(SUCCESS, true) put(ERROR, "") From fc6dd1992c031bb968fa285b1d0a96bfe81a5fd9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Gonz=C3=A1lez?= Date: Thu, 23 Oct 2025 13:53:53 +0200 Subject: [PATCH 2/2] fix test with new code --- .../duckduckgo/duckchat/impl/helper/RealDuckChatJSHelperTest.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/duckchat/duckchat-impl/src/test/kotlin/com/duckduckgo/duckchat/impl/helper/RealDuckChatJSHelperTest.kt b/duckchat/duckchat-impl/src/test/kotlin/com/duckduckgo/duckchat/impl/helper/RealDuckChatJSHelperTest.kt index bd8be7c280b3..997ee636b674 100644 --- a/duckchat/duckchat-impl/src/test/kotlin/com/duckduckgo/duckchat/impl/helper/RealDuckChatJSHelperTest.kt +++ b/duckchat/duckchat-impl/src/test/kotlin/com/duckduckgo/duckchat/impl/helper/RealDuckChatJSHelperTest.kt @@ -465,7 +465,7 @@ class RealDuckChatJSHelperTest { val result = testee.processJsCallbackMessage(featureName, method, id, data) val expectedPayload = JSONObject().apply { - put("selector", "document.getElementsByName('user-prompt')[0]?.focus();") + put("selector", "document.getElementsByName(''user-prompt'')[0]?.focus();") put("success", true) put("error", "") }