From ded4941d4c6ee3891240bdf0311354f3fcbe36e6 Mon Sep 17 00:00:00 2001 From: Cris Barreiro Date: Fri, 21 Nov 2025 11:28:18 +0100 Subject: [PATCH] Set password last-used timestamp upon creation --- .../autofill/impl/SecureStoreBackedAutofillStore.kt | 5 ++++- .../autofill/impl/SecureStoreBackedAutofillStoreTest.kt | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/SecureStoreBackedAutofillStore.kt b/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/SecureStoreBackedAutofillStore.kt index 55f5fdea6433..81e0b80e3ecf 100644 --- a/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/SecureStoreBackedAutofillStore.kt +++ b/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/SecureStoreBackedAutofillStore.kt @@ -167,11 +167,14 @@ class SecureStoreBackedAutofillStore @Inject constructor( logcat(INFO) { "Saving login credentials for $url. username=${credentials.username}" } + val timestamp = lastUpdatedTimeProvider.getInMillis() + val loginDetails = WebsiteLoginDetails( domain = url, username = credentials.username, domainTitle = credentials.domainTitle, - lastUpdatedMillis = lastUpdatedTimeProvider.getInMillis(), + lastUpdatedMillis = timestamp, + lastUsedInMillis = timestamp, ) val webSiteLoginCredentials = WebsiteLoginDetailsWithCredentials( details = loginDetails, diff --git a/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/SecureStoreBackedAutofillStoreTest.kt b/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/SecureStoreBackedAutofillStoreTest.kt index f5a3872edbad..a0e82481797e 100644 --- a/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/SecureStoreBackedAutofillStoreTest.kt +++ b/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/SecureStoreBackedAutofillStoreTest.kt @@ -547,7 +547,10 @@ class SecureStoreBackedAutofillStoreTest { ) testee.saveCredentials(url, credentials) - assertEquals(credentials.copy(domain = "example.com", lastUpdatedMillis = UPDATED_INITIAL_LAST_UPDATED), testee.getCredentials(url)[0]) + assertEquals( + credentials.copy(domain = "example.com", lastUpdatedMillis = UPDATED_INITIAL_LAST_UPDATED, lastUsedMillis = UPDATED_INITIAL_LAST_UPDATED), + testee.getCredentials(url)[0], + ) } @Test