Skip to content

Migrate MSP to databaseProvider #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: feature/cris/create-database-provider
Choose a base branch
from
Draft

Migrate MSP to databaseProvider #7194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions malicious-site-protection/malicious-site-protection-impl/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ dependencies {
implementation project(':browser-api')
implementation project(':design-system')
implementation project(':common-utils')
implementation project(':data-store-api')
implementation project(':navigation-api')
implementation project(':settings-api')

Expand Down
22 changes: 13 additions & 9 deletions ...n-impl/src/main/kotlin/com/duckduckgo/malicioussiteprotection/impl/MaliciousSiteModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ package com.duckduckgo.malicioussiteprotection.impl

import android.annotation.SuppressLint
import android.content.Context
import androidx.room.Room
import com.duckduckgo.data.store.api.DatabaseExecutor.Custom
import com.duckduckgo.data.store.api.DatabaseProvider
import com.duckduckgo.data.store.api.RoomDatabaseConfig
import com.duckduckgo.di.scopes.AppScope
import com.duckduckgo.malicioussiteprotection.impl.data.db.MaliciousSiteDao
import com.duckduckgo.malicioussiteprotection.impl.data.db.MaliciousSitesDatabase
Expand All @@ -35,7 +37,6 @@ import okhttp3.OkHttpClient
import retrofit2.Retrofit
import java.io.File
import java.security.MessageDigest
import java.util.concurrent.Executors
import java.util.concurrent.TimeUnit.SECONDS
import javax.inject.Named
import javax.inject.Qualifier
Expand All @@ -54,13 +55,16 @@ class MaliciousSiteModule {

@Provides
@SingleInstanceIn(AppScope::class)
fun provideMaliciousSiteProtectionDatabase(context: Context): MaliciousSitesDatabase {
return Room.databaseBuilder(context, MaliciousSitesDatabase::class.java, "malicious_sites.db")
.addMigrations(*ALL_MIGRATIONS)
.setQueryExecutor(Executors.newFixedThreadPool(4))
.setTransactionExecutor(Executors.newSingleThreadExecutor())
.fallbackToDestructiveMigration()
.build()
fun provideMaliciousSiteProtectionDatabase(databaseProvider: DatabaseProvider): MaliciousSitesDatabase {
return databaseProvider.buildRoomDatabase(
MaliciousSitesDatabase::class.java,
"malicious_sites.db",
RoomDatabaseConfig(
migrations = ALL_MIGRATIONS.toList(),
fallbackToDestructiveMigration = true,
executor = Custom(queryPoolSize = 1, transactionPoolSize = 4),
),
)
}

@Provides
Expand Down
Loading