From f3f7a25037b58383580cb96396d25f322131019b Mon Sep 17 00:00:00 2001 From: Cristian Monforte Date: Thu, 19 Mar 2020 15:51:11 +0100 Subject: [PATCH 1/2] Enabling search variants --- .../java/com/duckduckgo/app/statistics/VariantManagerTest.kt | 4 ++-- .../main/java/com/duckduckgo/app/statistics/VariantManager.kt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt b/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt index f5cf225e06ce..10e5736d7c39 100644 --- a/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt +++ b/app/src/androidTest/java/com/duckduckgo/app/statistics/VariantManagerTest.kt @@ -32,14 +32,14 @@ class VariantManagerTest { @Test fun serpControlVariantIsInactiveAndHasNoFeatures() { val variant = variants.first { it.key == "sc" } - assertEqualsDouble(0.0, variant.weight) + assertEqualsDouble(1.0, variant.weight) assertEquals(0, variant.features.size) } @Test fun serpExperimentalVariantIsInactiveAndHasNoFeatures() { val variant = variants.first { it.key == "se" } - assertEqualsDouble(0.0, variant.weight) + assertEqualsDouble(1.0, variant.weight) assertEquals(0, variant.features.size) } diff --git a/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt b/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt index 00a84b2d434b..fe20cc14aedf 100644 --- a/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt +++ b/app/src/main/java/com/duckduckgo/app/statistics/VariantManager.kt @@ -48,8 +48,8 @@ interface VariantManager { val ACTIVE_VARIANTS = listOf( // SERP variants. "sc" may also be used as a shared control for mobile experiments in // the future if we can filter by app version - Variant(key = "sc", weight = 0.0, features = emptyList(), filterBy = { noFilter() }), - Variant(key = "se", weight = 0.0, features = emptyList(), filterBy = { noFilter() }), + Variant(key = "sc", weight = 1.0, features = emptyList(), filterBy = { noFilter() }), + Variant(key = "se", weight = 1.0, features = emptyList(), filterBy = { noFilter() }), // Concept test experiment Variant(key = "mc", weight = 0.0, features = emptyList(), filterBy = { isEnglishLocale() }), From f9354a84cf40c12b361e4d9244bfb42f4bb7a83e Mon Sep 17 00:00:00 2001 From: Cristian Monforte Date: Thu, 19 Mar 2020 15:51:54 +0100 Subject: [PATCH 2/2] Finish LaunchBridgeActivity after routing to OnboardingActivity --- .../main/java/com/duckduckgo/app/launch/LaunchBridgeActivity.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/java/com/duckduckgo/app/launch/LaunchBridgeActivity.kt b/app/src/main/java/com/duckduckgo/app/launch/LaunchBridgeActivity.kt index 9b8c69ab9e15..1b0ad5a13a84 100644 --- a/app/src/main/java/com/duckduckgo/app/launch/LaunchBridgeActivity.kt +++ b/app/src/main/java/com/duckduckgo/app/launch/LaunchBridgeActivity.kt @@ -67,6 +67,7 @@ class LaunchBridgeActivity : DuckDuckGoActivity() { } else { startActivity(OnboardingActivity.intent(this)) } + finish() } private fun showHome() {