This repository has been archived by the owner on Nov 19, 2021. It is now read-only.
IA Pages - find the correct IA regardless of letter casing in the URL #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariagraziaAlastra
changed the title
| @@ -595,7 +595,7 @@ sub ia_base :Chained('base') :PathPart('view') :CaptureArgs(1) { # /ia/view/cal | |||
| my ( $self, $c, $answer_id ) = @_; | |||
|
|
|||
| $c->stash->{ia_page} = "IAPage"; | |||
| $c->stash->{ia} = $c->d->rs('InstantAnswer')->find({meta_id => $answer_id}); | |||
| $c->stash->{ia} = $c->d->rs('InstantAnswer')->find({meta_id => lc $answer_id}); | |||
There was a problem hiding this comment.
Are we absolutely sure there are no mixed case meta_ids in existing data?
There was a problem hiding this comment.
We shouldn't... but I'm starting to have doubts now!
There was a problem hiding this comment.
You can do something like this to be extra sure.
https://github.com/duckduckgo/community-platform/blob/65368f8/script/ddgc_revokeadmin.pl#L18
my $user = $schema->resultset('User')->search( \[ 'LOWER(me.username) = ?', ( lc($username) ) ] )->one_row;Thanks!
|
@jbarrett Thanks, changes made! |
|
👍 Thanks, @MariagraziaAlastra! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description :
Redirect to the correct IA Page even if the meta_id in the URL contains uppercase chars.
Reviewer notes :
How to test this manually:
References issues / PRs:
Who should be informed of this change?
@tagawa @russellholt
Does this change have significant privacy, security, performance or deployment implications?
Checklist :