From 5fb2eebe411c89d7c394cc1e9fa72b93837db0ed Mon Sep 17 00:00:00 2001 From: Moon Kyong Date: Wed, 22 Oct 2025 11:54:07 -0700 Subject: [PATCH 1/3] Set line-height to normal -- this fixes cut-off issue on windows, but does not change anything on mac os --- .../new-tab/app/omnibar/components/SearchForm.module.css | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css b/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css index d17d2954e7..df79303836 100644 --- a/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css +++ b/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css @@ -16,12 +16,13 @@ padding-right: calc(var(--suffix-text-width) + var(--sp-1) + var(--sp-8) + var(--sp-1)); /* Suffix + padding + close button + padding */ position: absolute; right: 0; + line-height: normal; &::placeholder { color: var(--ntp-text-tertiary); } - [data-platform="windows"] &::selection { + [data-platform='windows'] &::selection { background: var(--ntp-selection-background-color); color: var(--ntp-selection-color); } @@ -78,7 +79,7 @@ visibility: visible; } - [data-entry-point="omnibar"]:has([role="listbox"]) & { + [data-entry-point='omnibar']:has([role='listbox']) & { visibility: visible; } } From 03e940ef596521b249a1321d3a88f58c31c9bcd7 Mon Sep 17 00:00:00 2001 From: Moon Kyong Date: Wed, 22 Oct 2025 12:00:31 -0700 Subject: [PATCH 2/3] Target windows only --- .../new-tab/app/omnibar/components/SearchForm.module.css | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css b/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css index df79303836..69f9f9ce5a 100644 --- a/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css +++ b/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css @@ -16,7 +16,6 @@ padding-right: calc(var(--suffix-text-width) + var(--sp-1) + var(--sp-8) + var(--sp-1)); /* Suffix + padding + close button + padding */ position: absolute; right: 0; - line-height: normal; &::placeholder { color: var(--ntp-text-tertiary); @@ -83,3 +82,9 @@ visibility: visible; } } + +[data-platform-name='windows'] { + .input { + line-height: normal; + } +} \ No newline at end of file From 3e0a1f89e95f31756411dd15aab75532c7f6459b Mon Sep 17 00:00:00 2001 From: Moon Kyong Date: Wed, 22 Oct 2025 13:22:44 -0700 Subject: [PATCH 3/3] use data-platform for naming consistency --- .../pages/new-tab/app/omnibar/components/SearchForm.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css b/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css index 69f9f9ce5a..25732bb4c8 100644 --- a/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css +++ b/special-pages/pages/new-tab/app/omnibar/components/SearchForm.module.css @@ -83,7 +83,7 @@ } } -[data-platform-name='windows'] { +[data-platform='windows'] { .input { line-height: normal; }