Decouple theme provider from messaging bridge #2074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: N/A
Description
Refactors the
ThemeProviderin the history special page to improve encapsulation. Instead of directly subscribing to theme updates viahistory.messaging.subscribe,ThemeProvidernow calls a newonThemeUpdatemethod on theHistoryPageinstance. This centralizes messaging bridge interactions withinHistoryPage, aligning with patterns used in other special pages.Testing Steps
Checklist
Please tick all that apply:
Note
Adds
HistoryPage.onThemeUpdateand updatesThemeProviderto subscribe via this API instead of accessingmessagingdirectly.special-pages/pages/history/src/index.js):onThemeUpdate(callback)that delegates tothis.messaging.subscribe('onThemeUpdate', callback).special-pages/pages/history/app/global/Providers/ThemeProvider.js):history.messaging.subscribe('onThemeUpdate', ...)withhistory.onThemeUpdate(...)for theme updates.Written by Cursor Bugbot for commit 1d17970. This will update automatically on new commits. Configure here.