-
Notifications
You must be signed in to change notification settings - Fork 31
Special Error: Stub out support for theming #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Thu, 04 Dec 2025 01:07:00 GMT Apple
File has changed Integration
File has changed Windows
File has changed |
Co-authored-by: randerson <randerson@duckduckgo.com>
|
Cursor Agent can help with this pull request. Just |
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1211842297547582
Updates
initialSetupand addsonThemeUpdateto allow setting athemeandthemeVariantper https://app.asana.com/1/137249556945/project/1209121419454298/task/1212083006586484?focus=true.Adjusts the default background colour according to the set variant so that something observable happens when setting a theme.
Intention here is to do the minimal amount needed to unblock the native apps. In follow up PRs I’ll import theme variables from the design-tokens repo and update more than just the background colour.
Testing Steps
Checklist
Please tick all that apply:
Note
Adds ThemeProvider-driven theming to Special Error, supporting theme/themeVariant via initialSetup and onThemeUpdate, updates CSS variables, and adds integration tests.
ThemeProviderto derive/applydata-themeanddata-theme-variantonbody(frominitialSetup,onThemeUpdate, or system preference).ThemeProvideraroundApp/Components; removes per-element theme onApp.jsx.public/index.htmlto use a$LOADING_COLOR$for initial background.styles/variables.cssto use body data attributes; adds theme variants (coolGray,slateBlue,green,violet,rose,orange,desert) and iOS dark default tweak.initialSetup.responsewith optionalthemeandthemeVariant.onThemeUpdate.subscribeand enums forBrowserTheme/ThemeVariant; exposesonThemeUpdateAPI onSpecialErrorPageandsubscribein types.theme/themeVariantvia URL params.special-error-theme.spec.jsand helpers (hasTheme,hasBackgroundColor,acceptsThemeUpdate,additionalinitial setup overrides).Written by Cursor Bugbot for commit c6fcae8. This will update automatically on new commits. Configure here.