Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for mis-translations in Canadian French #104

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
4 participants
@tagawa
Copy link
Member

commented Apr 26, 2019

Thanks to a user for pointing this out.

@tagawa tagawa requested a review from moollaza Apr 26, 2019

@moollaza

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

@tagawa unfortunately my skills are pretty lacking these days. I would rely on someone else, perhaps @AdamSC1-ddg or @bbraithwaite?

@tagawa tagawa requested review from bbraithwaite and removed request for moollaza Apr 27, 2019

@tagawa tagawa assigned bbraithwaite and unassigned moollaza Apr 27, 2019

@tagawa

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2019

Understood.

@bbraithwaite , are you a suitable candidate for reviewing this please?

@jbarrett

This comment has been minimized.

Copy link
Member

commented May 1, 2019

These are a clear improvement - merging.

@jbarrett jbarrett merged commit 67356fd into master May 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jbarrett jbarrett deleted the tagawa/french branch May 1, 2019

@bbraithwaite

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Sorry I missed this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.