Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh_CN translation #116

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
3 participants
@b9a1
Copy link
Contributor

commented May 14, 2019

Some questions about the new tokens:

msgid "Customize DuckDuckGo"
msgid "Personalize DuckDuckGo"
msgid "Prompt me to customize my DuckDuckGo experience."
msgid "Prompt me to personalize my DuckDuckGo experience."

What’s the difference between ‘customize’ and ‘personalize’?

msgid "Show most visited links on new tab page"

New tab page of the browser? How could DuckDuckGo control that page?

@jbarrett

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Thank you @b9a1! Sorry for the delay in responding. I've pinged the developers for further info on these strings - hopefully should have a response later today.

@jbarrett jbarrett self-assigned this May 16, 2019

@gtfiorentino

This comment has been minimized.

Copy link

commented May 24, 2019

Hi @b9a1! The new tab page is a browser feature that Chromium browsers allow the default search engine to control. DuckDuckGo was recently added as a default search engine option, and so we are in the process of creating the new tab page that users will see when they set DuckDuckGo as their default. You can see a preview in a beta version of Chrome, and we expect the page to be available to everyone in Chrome 75.

@b9a1

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

@gtfiorentino That’s awesome, thank you!

Since I don’t see the customize/personalize options in the current Settings page, I’ll update the rest of new tokens first.

@b9a1 b9a1 marked this pull request as ready for review May 30, 2019

@b9a1 b9a1 force-pushed the b9a1:update branch from 8e3fe2a to 75cfe84 May 30, 2019

@jbarrett

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Thank you @b9a1! There is no effective difference between "personalize" and "customize" but since those tokens are no longer used, they should be cleaned up soon anyway.

👍

@jbarrett jbarrett merged commit 2121ecb into duckduckgo:master Jun 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@b9a1 b9a1 deleted the b9a1:update branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.