Skip to content

Change cores count to 2#722

Merged
Charlie-belmer merged 1 commit intodevelopfrom
change-cores
Jul 6, 2021
Merged

Change cores count to 2#722
Charlie-belmer merged 1 commit intodevelopfrom
change-cores

Conversation

@jonathanKingston
Copy link
Copy Markdown
Collaborator

Reviewer: @Charlie-belmer

Description:

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Copy link
Copy Markdown
Contributor

@Charlie-belmer Charlie-belmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@Charlie-belmer Charlie-belmer merged commit 5a259e4 into develop Jul 6, 2021
@jonathanKingston jonathanKingston deleted the change-cores branch January 24, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants