Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when undoing #463

Merged
merged 6 commits into from Jul 29, 2019
Merged

Fix crash when undoing #463

merged 6 commits into from Jul 29, 2019

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/856498667320406/1133035446878373
Tech Design URL:
CC:

Description:

  • Fix for the crash.
  • There was an inconsistency between how following scenarios were handled:
    • Clearing search bar by using backspace.
    • Clearing search by using clear button.

In one case autocomplete list has been cleared, in other not.

Steps to test this PR:

Crash scenario:

  1. Open app on the iPad.
  2. Write something in search field. Try undoing.

Also, please make sure there are no glitches on both home screen (in simple and centered search modes) and in browsing mode with regard to omni bar activity and state changes.


Internal references:

Software Engineering Expectations
Technical Design Template

@bwaresiak bwaresiak requested a review from brindy as a code owner July 26, 2019 21:50
let testee = HomeTextEditingState()
XCTAssertTrue(testee.clearTextOnStart)
XCTAssertFalse(testee.clearTextOnStart)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brindy Was there any particular reason why this was made this way in the first place? I tried to break this after the change and it seems to work - but I'm afraid I've missed something.

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

In answer to your question - I don't remember why it was like that. Sorry!

@bwaresiak bwaresiak merged commit 55f5721 into develop Jul 29, 2019
@bwaresiak bwaresiak deleted the feature/crash_on_undo branch July 29, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants