Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
...
This comparison is big! We're only showing the most recent 250 commits
Commits on Nov 03, 2014
@moollaza moollaza slight phrasing change a07be8d
Commits on Nov 04, 2014
@mwmiller mwmiller bin/duckpan: minor documentation fixes.
- Remove an errant :
- Document server cachesec
83b514c
@mwmiller mwmiller Merge pull request #159 from duckduckgo/zaahir/duckpan-empty
Added empty command, updated and reorganize docs
6dbec9e
@mwmiller mwmiller duckpan: fail on missing include directory.
Using realpath instead of user-entered string, in order to possibly help
them spot the problem.

Addresses #156.
768b505
@mwmiller mwmiller bin/duckpan: give them the absolute path, if we can't get realpath
I still think the realpath is more useful, but if throws an exception,
just go with absolute.

The absolute is not in a `catch` block, because we lose our `$_`.  If
this was any more complex I would write it a different way.

Also, split out into to sub-tests.
e767ebf
@moollaza moollaza Don't be so quick to throw the manpage in my face
This has bugged me for a long time...
106f9cc
@moollaza moollaza Add a period to error message 6ec9a31
@moollaza moollaza Small update to phrasing 666b2e0
Commits on Nov 05, 2014
@mwmiller mwmiller DuckPAN: dead code elimination.
Remove a line which could never be hit.
e7099c7
@mwmiller mwmiller Merge pull request #161 from duckduckgo/zaahir/calm-down-duckpan
Don't be so quick to throw the manpage in my face
752f8af
@moollaza moollaza Merge pull request #157 from mwmiller/inclusiveness
duckpan: fail on missing include directory.
3b4b344
Commits on Nov 07, 2014
@mwmiller mwmiller DuckPAN: store and parse module list once.
Rather than redownloading a couple (or more) times in a row and
re-parsing, just parse it once per run.

- Eliminates duckpan_packages as an option, but that seemed silly.
- File is mirrored instead of gotten and stored, may make things very
  slightly faster on slow connections.
- File is parsed just once per application run.
4895b6d
@mwmiller mwmiller DuckPAN: make reinstall do reinstall.
force is much more dangerous, ignoring test results and the whole
ordeal.  This should reinstall if it's possible.
a38a01c
@mwmiller mwmiller Perl: simplify module version checking.
This makes things slightly easier to follow for the next person.  I
suspect I'll be back here soon and I like my sanity.
09ab54d
@mwmiller mwmiller Perl: make pinned versions work.
We don't have access to an export which allows us to find previous
distributions, but we can assert a bunch of shaky premises and try to
find it anyway.
46f4dde
@mwmiller mwmiller Perl: allow pinning for uninstalled packages.
We've always required that we have a local version against which we
compare.  But if it's not installed at all, we'd miss the comparisons
with the pinned version.  So, let's give it a value against which to
compare.

Hopefully that value is silly enough.
a6007cf
@mwmiller mwmiller DuckPAN: use a more reasonable terminal width for `print_text`.
If we can figure out their width, we might as well use it so we get a
nicer output.

I don't feel comfortable writing cross-platform code to determine when
the width may have changed, so I'll leave that for smarter people.
3206aa6
@mwmiller mwmiller App::DuckPAN: move verbose option to App level.
There's no particular reason why verbosity should be set on only the
server command level.  If we move it here, we can better unify logging
and create a more consistent interface.

This is a breaking change for scripts which expect the other ordering,
but it will really improve things.  So let's do it now, early in
product up-take.
da50bc8
@mwmiller mwmiller App::DuckPAN: add and use verbose message.
We abviously aren't _overly_ concerned about speed, so the early return
guard there is mostly in case we decide we want to mutate the output or
something else fancy inside `verbose_msg`
2143d75
@mwmiller mwmiller DuckPAN: switch print_text to show_msg.
This creates a more consistent API and is easier to think about in a
general way.

`exit_with_msg` stays as it is, because an extra argument is required
which should be slightly more obvious with the naming difference.
c563293
@mwmiller mwmiller Replace print with show_msg.
We want a consistent way of outputting messages, so all of the print
statements with access to the App are converted to use its outputters.
9cf7498
@mwmiller mwmiller App::DuckPAN: add warning_msg and error_msg.
Still more abstracting of the output such that we can potentially do
interesting things with it later

Also:
- Move meat of show_msg into _print_msg with filehandle passing.
- Put error_msg on to STDERR via the above facility.
- Minorly refactor _print_msg for slightly tighter output and better
  comprehensibility.
487f3d1
@mwmiller mwmiller DDG: turn per-class loads into verbose messages.
It all scrolls by so quickly that it is unlikey to help.  It's mostly
the unable to load messages which are of interest. Those also become
warnings herein.
125a020
@mwmiller mwmiller Direct Data::Printer output to msg mechanisms.
This way the info gets caputred in the same ways.
42de57d
@mwmiller mwmiller DuckPAN: drop line splitting.
It's a lot of wasted cycles in 2014 to do this kind of thing.  If
someone cares, they probably have a terminal setting to do it.  If they
don't, the cycles are even more wasted.

Includes some message review work as well, in an attempt to make sure
this isn't insane.
c110cd8
@mwmiller mwmiller DuckPAN: prepend log level on each line.
With the word splitter gone we can better format these messages such
that if they span several lines, they look "blocky" enough to logically
group.
5036ef9
@mwmiller mwmiller DuckPAN: update some message outputs.
Having run this, I saw some places where the messages are less
appealing, now that each line ends.  This is fixing up some of that.
c58c3da
@mwmiller mwmiller Covert DOS to UNIX line-endings.
I have enough trouble with the mixed tabs and spaces; I don't need this
hassle, too.
4602bdb
@mwmiller mwmiller DuckPAN: improve exit_with_msg for good and bad exits.
There's no point in yapping about a FATAL ERROR when the exit is 0.
Also, if it IS an error send it to STDERR.
d6bf6a6
@mwmiller mwmiller DuckPAN: improve switch documentation 344f059
@mwmiller mwmiller DuckPAN: use _print_msg internally.
This fixes a bug with exit_with_msg.. as well as preparing for the
future goodness.

Also, a mis-aligned exit code for the unknown command path.
8edd367
@mwmiller mwmiller DuckPAN: add colored prefixes.
This isn't too distracting, but maybe adds some value.  Also, not
expected to be the final version.
58a08bb
Commits on Nov 08, 2014
@mwmiller mwmiller DuckPAN: rearrange outputting, again.
- Organize into 'emit_<msg_type>'
- Prefix pretty much everything.
- Add fixed-width prefix-maker
9573232
Commits on Nov 09, 2014
@moollaza moollaza Merge pull request #162 from duckduckgo/mwm/faster_duckpan
DuckPAN: store and parse module list once.
750a4f4
@moollaza moollaza remove colour and prefix from standard and verbose output e5b20f3
Commits on Nov 10, 2014
@mwmiller mwmiller DuckPAN: move prefix-appending into `_print_msg`
This may (or may not) make it easier to do more interesting things with
the various kinds of output.
169a562
@mwmiller mwmiller Server: left-align ProgressBar.
Already seeing the problems with something which doesn't go through the
`emit` process.  It's still helpful, but it requires extra maintenance
effort when the assumptions change.
bcb0841
@mwmiller mwmiller DuckPAN: bold all prefix lines, NOTE -> NOTICE
The intention is to have them stand out a bit, so this should help.
In the old case, it could blend in with the output if the user happens
to be using a chosen color as their base color, since there aren't
any obvious prefixes on the standard output. If people run with bold all
the time, they deserve what they get.

I dunno why I like NOTICE better, but I somehow do. This means expanding
the prefix_width.. which might be moot now that we don't always prefix.
a6033af
@mwmiller mwmiller Server: include file info prefix on errors.
If you're not in verbose mode these messages won't make any sense,
otherwise.
c87d99f
@mwmiller mwmiller DuckPAN: improve check_requirements.
This makes it just exit on its own when requirements checking fails.

Also, improve both message text and "emission levels."

Also removes verify_versions which was not well-integrated.  This
involves extra checking on git and SSH which didn't happen to much
before, but is fairly cheap in the grand scheme of things.
1eae4b2
Commits on Nov 11, 2014
@killerfish killerfish update env path 0128975
@killerfish killerfish update env path 36933bd
@moollaza moollaza Merge pull request #165 from killerfish/docupdate
Updated docs for env path
0555ce5
@killerfish killerfish added help command 080dad6
@moollaza moollaza Merge pull request #168 from killerfish/addhelpcmd
Added help command for duckpan
4ceb4eb
Commits on Nov 12, 2014
@moollaza moollaza Merge pull request #164 from duckduckgo/mwm/verbosity
Improve Output
31221de
Commits on Nov 13, 2014
@killerfish killerfish update indentation 0f96da4
@killerfish killerfish changed func names 6263af5
@killerfish killerfish updated env to accomodate new commands f82a21b
@moollaza moollaza Fixed POD formatting, output currently broken 75fd869
@moollaza moollaza Make sure DuckPAN w/o arguments show Help info c588db9
@moollaza moollaza Update tests to make sure duckpan and duckpan help work 2cf2d7c
@moollaza moollaza lots of updated, not working as expected 9f5df9a
@moollaza moollaza Update tests to match new Help text 4cf8ee0
@moollaza moollaza Convert tabs to spaces 3a1c396
@moollaza moollaza Big reformat of POD, closer to true POD syntax 3463c3b
@moollaza moollaza Update Help to output SYNOPSIS only for duckpan w/o args fda1f01
@moollaza moollaza Update tests to match new outut 77c7d42
@mwmiller mwmiller Merge pull request #170 from duckduckgo/zaahir/pod2usage-improvements
DuckPAN Help and pod2usage Improvements
381e2d6
@killerfish killerfish Updated and added functionality for env subcommands 9d4edef
@killerfish killerfish modified test 03a4452
Commits on Nov 14, 2014
@killerfish killerfish removed useless import c4c0894
Commits on Nov 15, 2014
@mwmiller mwmiller DuckPAN: deal with incompatible versions of PCPF.
Either of the changes by itself should fix this, but why not both?

- Ask for version 0.8 of Parse::CPAN::Packages::Fast
- Wastefully send the filename to the parser

If the first one doesn't move them up, the second one will make it work
with the old interface.
5c973d5
Commits on Nov 17, 2014
@killerfish killerfish not using moox options so removed it bec7283
@moollaza moollaza Merge pull request #173 from duckduckgo/mwm/insanity
DuckPAN: deal with incompatible versions of PCPF.
a1597dc
Commits on Nov 18, 2014
@mwmiller mwmiller DuckPAN: change --no_check to --check.
Also, make is negativeable so that --no-check works.  This is a more
standard way of doing these kind of options.
e891bd5
@mwmiller mwmiller DuckPAN: add option to turn on/off colored output
Defaults to colors on, can be switched off with --no-colors.

This doesn't work so well with the Web portions, which don't have access
to duckpan switches.

Fixes #29.
c4cfd81
@mwmiller mwmiller Simplify cache handling.
- Change 'empty' command to '--empty' switch.
- Remove '--force' from Server.
- Remove '--cachesecs' from Server.

This allows other commands (say, `query`) to benefit from the same
cache-handling as the `server` command.

If we just empty the cache up-front then we don't have to keep checking
to see if there was a force.  We can just see if they exist and are new
enough.
2c8bbad
@mwmiller mwmiller DuckPAN: make --no-check turn off all checking.
If this is not what is intended, we should probably rename the switch.

Also, do an empty_cache in check to more generally require a
full re-check.
7cad82a
@mwmiller mwmiller Add doc strings for existing commands.
TshHey can be seen with --help.. which feels quite conflicting with the
'help' command.  Not sure what to think about that.
ab7f963
@GregorioMartinez GregorioMartinez README.md - Fixing Codio Project Template link in documentation afa985c
@killerfish killerfish Condition added to handle if no arguments supplied 209837d
@killerfish killerfish updated with missing messages 1b1c381
@killerfish killerfish namespaced Env cmds under Env 1c60cbb
@moollaza moollaza Merge pull request #177 from GregorioMartinez/master
README.md - Fixing Codio Project Template link in documentation
c915475
@killerfish killerfish updated to support help properly b47cbd7
@moollaza moollaza remove reference to deleted empty cmd, fix commands output 80129b1
Commits on Nov 19, 2014
@mwmiller mwmiller Merge pull request #178 from duckduckgo/zaahir/duckpan-help-updates
remove references to deleted `empty` cmd, fix `duckpan` output
4b91d8f
@moollaza moollaza Merge pull request #174 from duckduckgo/mwm/options
Options updates.
f6dbd31
@killerfish killerfish updated test 2b27506
Commits on Nov 20, 2014
@killerfish killerfish removed ternary f5bf434
@moollaza moollaza Merge pull request #181 from killerfish/aha!
Fix for duckpan (#180)
e875c42
@moollaza moollaza v0.165 7d2d05a
Commits on Nov 24, 2014
@mikedep333 mikedep333 README.md: Add: Using DuckPAN: Prerequisites For Instant Answer Devel…
…opers
1f5ee54
@mikedep333 mikedep333 README.md: Clarification: Add link in VM section to Using DuckPAN sec…
…tion
b8d71c4
@mikedep333 mikedep333 README.md: Update instructions for the new DuckDuckHack VM (created w…
…ith Vagrant)
d6014b0
Commits on Nov 26, 2014
@moollaza moollaza Normalize usage of MooX::Options in Cmds 2afd689
@moollaza moollaza Merge pull request #183 from duckduckgo/zaahir/normalize-moox-options…
…-usage

Normalize usage of MooX::Options in Cmds
2f0db53
@moollaza moollaza Update Spice.js to redefine Spice.failed for frontend notification
Now when Spice.failed is called our redefined function first calls the
original Spice.failed, but then adds an alert onto the page so the
developer is aware of which Spices failed. Otherwise they just see a
blank page which doesn't explain what you are seeing
73b710c
@moollaza moollaza Normalize usage of single quotes c38672a
Commits on Nov 27, 2014
@killerfish killerfish updated env to use MooX::Cmd 5ee8413
Commits on Nov 28, 2014
@NeoSilky NeoSilky Fixed some spelling mistakes in help 946556a
Commits on Nov 29, 2014
@moollaza moollaza Merge pull request #185 from NeoSilky/master
bin/duckpan - Fixed some spelling mistakes in help
67b5f2b
@moollaza moollaza Better use of jQuery to build div obj, create spice-error container d…
…iv on page load
6711025
@moollaza moollaza Merge pull request #171 from killerfish/updateenv
Improved Env command
e0a6f59
Commits on Dec 01, 2014
@mikedep333 mikedep333 Move the "Prerequisites For Instant Answer Developers" section to the…
… "Cloning the repository on the VM" section
311e577
@mikedep333 mikedep333 Update instructions on importing the VM for the new 2014 VM, and for …
…clarity.
008f38a
@killerfish killerfish update readme for env a9cf713
@killerfish killerfish add missed tick 69c7dc5
@killerfish killerfish updated pod for env 5256510
@moollaza moollaza Merge pull request #187 from killerfish/updatedocsenv
Update docs for env
4585fe2
@moollaza moollaza Merge pull request #184 from duckduckgo/zaahir/spice-failed-notice
Spice.failed() frontend notice
8b0a420
Commits on Dec 03, 2014
@moollaza moollaza Pass @args along to cpanm, allows --force, --verbose, etc af252a5
@moollaza moollaza Merge pull request #188 from duckduckgo/zaahir/install-pass-args
Pass @args along to cpanm, allows --force, --verbose, etc
40091ad
Commits on Dec 04, 2014
@killerfish killerfish add highlight on failed req 36cca9d
@moollaza moollaza Merge pull request #189 from killerfish/highlight
Web: Highlight on failed request
aee1cb5
Commits on Dec 05, 2014
@zachthompson zachthompson * Use POE events to create the "infinite loop" effect in APP::DuckPAN…
…::Query; tidy up some other areas

* Pass @blocks as a reference in A::D::Cmd:Query
6228285
@zachthompson zachthompson * Small adjustments 9b7b517
Commits on Dec 06, 2014
@zachthompson zachthompson * Fix rogue indentations 057a155
@zachthompson zachthompson * use Try::tiny 2f0fed0
Commits on Dec 07, 2014
@killerfish killerfish Display error instead of redirecting ca5d30e
@killerfish killerfish remove function since we dont need it for redirect error df781dc
Commits on Dec 08, 2014
@zachthompson zachthompson * Comment some of the less obvious code. 96d1a0a
Commits on Dec 09, 2014
@zachthompson zachthompson * Change requires to uses in A::D::Query 4a15d96
@zachthompson zachthompson * Fix typo/addition comment b81b009
@zachthompson zachthompson tabs...alas c91785f
Commits on Dec 14, 2014
@mikedep333 mikedep333 Update README.md for the 2014-12-13 VMs 8f34d08
Commits on Dec 15, 2014
@zachthompson zachthompson * Add _stop event to explicitly get rid of Wheel::Readline so that it…
… can restore console
0302d58
@zachthompson zachthompson * Restart duckpan apps in a general way upon detecting changes in fil…
…es in the development hierarchy.

Apps can declare _run_app() in their package and use App::DuckPAN::Restart.  Changes should be as easy as:
1. use Moo;
   with qw(App::DuckPAN::Restart);
2. Rename run() _run_app()
3. sub run {
      ....
      $self->run_restarter(\@args);
   }
1256dd8
Commits on Dec 16, 2014
@zachthompson zachthompson remove unnecessary uses; restore the exit() d283b40
Commits on Dec 17, 2014
@zachthompson zachthompson * Add SIGTERM handler 38d7858
@zachthompson zachthompson * Remove debugging, comment 81335b0
@zachthompson zachthompson * Sync with branch app_restart 9ff625e
Commits on Dec 19, 2014
@moollaza moollaza Merge pull request #192 from killerfish/fixerr
Web: Show error instead of redirecting
907b1bd
Commits on Dec 22, 2014
@mikedep333 mikedep333 linebreak between codeblock and paragraph
We need a linebreak between the codeblock and paragraph (to avoid problems for the markdown parser)
657b7dd
Commits on Dec 23, 2014
@mikedep333 mikedep333 Update for 2014-12-23 VMs e1c610e
@moollaza moollaza Merge pull request #182 from mikedep333/new-2014-duckduckhack-vm
README.md updates for the new DuckDuckHack VM
ce9ddcb
@moollaza moollaza Fix VBox and VMWare .ova links 3c5f0f7
@mikedep333 mikedep333 VMs: Revert MD5 and filenames to 2014-12-13
There was a miscommunication in #182. The 2014-12-23 VMs have not been uploaded yet. The 2014-12-13 VMs are older but have been uploaded, so let's specify their details.
27df559
@moollaza moollaza Merge pull request #197 from mikedep333/new-2014-duckduckhack-vm
VMs: Revert MD5 and filenames to 2014-12-13
2a712c8
Commits on Dec 25, 2014
@zachthompson zachthompson * Remove some unnecessary use's 82a4f49
Commits on Jan 08, 2015
@nilnilnil nilnilnil Merge pull request #190 from zachthompson/poe_query
Modify A::D::Query to use POE events rather than while(1)
3198eb1
@zachthompson zachthompson * Add comments for some of the less clear logic c438a78
@zachthompson zachthompson * Merge conflicts a78c6cc
Commits on Jan 09, 2015
@zachthompson zachthompson * Exit immediately if not in IA directory 21b741a
@nilnilnil nilnilnil Merge pull request #196 from zachthompson/app_restart
Automatic duckpan app restart on IA update
299c9ae
Commits on Jan 23, 2015
@moollaza moollaza Add File::Find::Rule and Filesys::Notify::Simple to dist 9158023
@moollaza moollaza Merge pull request #202 from duckduckgo/zaahir/update-distini
Add File::Find::Rule and Filesys::Notify::Simple to dist
78a2e2e
@moollaza moollaza Remove conditionally defining $VERSION, allow PkgVersion to set it
This caused problem during the most recent release of DuckPAN.
PkgVersion did not set a $VERSION for App::DuckPAN because it detected $VERSION was being defined in the code.
This resulted in App::DuckPAN not having any $VERSION in the final build, which meant the DuckPAN package had
no version on duckpan.org

This is causing problems for App::DuckPAN because it thinks the local version is now higher than what duckpan.org has (version 0),
which means duckpan will not upgrade!

This fix removes any explicit definition of $VERSION so PkgVersion can set it properly.
1873a54
@moollaza moollaza Merge pull request #204 from duckduckgo/zaahir/fix-app-duckpan-versio…
…ning

Remove conditionally defining $VERSION, allow PkgVersion to set it
076547d
@zachthompson zachthompson App::DuckPAN::Query: revert to require DDG::* so travis builds will s…
…ucceed on github
e65ddac
@moollaza moollaza Update Travis.yml to allow for faster Travis builds 95f483d
@moollaza moollaza Merge pull request #205 from duckduckgo/zach/require-for-travis
App::DuckPAN::Query: revert to require DDG::* for travis
9f55b35
@moollaza moollaza Merge pull request #206 from duckduckgo/zaahir/travis-docker-builds
Update Travis.yml to allow for faster Travis builds
5ba423e
Commits on Jan 26, 2015
@gitter-badger gitter-badger Added Gitter badge 20870a8
@moollaza moollaza Revert "Update Travis.yml to allow for faster Travis builds" 8617bb8
@moollaza moollaza Merge pull request #208 from duckduckgo/revert-206-zaahir/travis-dock…
…er-builds

Revert "Update Travis.yml to allow for faster Travis builds"
33ab876
Commits on Jan 27, 2015
@moollaza moollaza Skip env tests until we know why they intermittently fail 484a29e
@zachthompson zachthompson App::DuckPAN::Web: Add support for specifying built-in Spice template…
…s with Goodies
2867656
@zachthompson zachthompson App::DuckPAN::Web: Clean up whitespace 4e4f767
Commits on Jan 28, 2015
@mikedep333 mikedep333 Fix #201 - Replace Vagrant instructions with link 3e09d69
@mikedep333 mikedep333 Update VMs: 2014-12-13 -> 2014-12-23 fb7cdf5
@moollaza moollaza Merge pull request #214 from mikedep333/2014-12-23-vm
Update VMs: 2014-12-13 -> 2014-12-23
8ff4804
@zachthompson zachthompson App::DuckPAN::Web: Slightly modified logic which will perhaps make it
easier to display multiple goodies and add custom templates down the
road.
004aa7f
@moollaza moollaza Merge pull request #211 from duckduckgo/zaahir/skip-env-test
Skip env tests until we know why they intermittently fail
598f59e
@moollaza moollaza Merge pull request #213 from mikedep333/fix-201
Fix #201 - Replace Vagrant instructions with link
32f3c76
@mikedep333 mikedep333 Make the Vagrant Setup Instructions easier to find
I am incorporating the feedback from @moollaza in PR #213
576597a
Commits on Jan 29, 2015
@moollaza moollaza Merge pull request #212 from duckduckgo/zach/goodie-template-v2
Support built-in templates for Goodies
2df4c02
@moollaza moollaza Provide 'dev' VERSION for DuckPAN when no VERSION exists a6b4eed
@moollaza moollaza Improved messaging when current module version is outdated 476d0d3
@moollaza moollaza Provide version 9.999 when no defined 40bfdf8
@moollaza moollaza Add comment to get_local_version a047ca3
@moollaza moollaza Merge pull request #209 from duckduckgo/zaahir/duckpan-versioning
DuckPAN Dev Versioning
b12671b
@moollaza moollaza Provide more information when installing module for the first time 5ac6a8a
@moollaza moollaza Merge pull request #216 from duckduckgo/zaahir/informative-install
Provide more information when installing module for the first time
4e7c0bb
@mikedep333 mikedep333 README.md: Fix #setup-instructions anchor
This bug was carried over from before #201 was fixed.
e1119f3
@moollaza moollaza Remove failing tests, exception still causing failure 6ce7003
@moollaza moollaza Merge pull request #217 from duckduckgo/zaahir/remove-tests
Remove failing tests, exception still causing failure
e623b65
@moollaza moollaza Merge pull request #215 from mikedep333/fix-201-clarification
Make the Vagrant Setup Instructions easier to find
ead5576
Commits on Jan 30, 2015
@zachthompson zachthompson App::DuckPAN:Restart: Skip restarting server on changes to .js|css|ha…
…ndlebars files as they are loaded every time.
13382bd
@MrChrisW MrChrisW Merge pull request #218 from duckduckgo/zach/skip-share-reload
App::DuckPAN:Restart: Skip restarting server on changes to .js|css|handlebars
07ad225
Commits on Feb 05, 2015
@zachthompson zachthompson App::DuckPAN::Web: Modifications to allow custom goodie templates. No…
…te: still has race condition that needs to be addressed in the javascript. For now, uses setTimeout with an arbitrary delay.
fbf4093
Commits on Feb 10, 2015
@zachthompson zachthompson App::DuckPAN::Web: Goodies can have js as well, e.g. for Handlebars h…
…elpers.

duckpan.js: Check that it's a function first. Goodies with javascript can generate errors here.
6b7bd1c
@moollaza moollaza Inject mock ad and results into SERP for realistic look b001588
@moollaza moollaza Update install/reinstall message to be more clear 1fb96b0
@moollaza moollaza Merge pull request #220 from duckduckgo/zaahir/informative-install
Update install/reinstall message to be more clear
274690d
@zachthompson zachthompson App::DuckPAN::Web: Add commment about removing setTimeout line when j…
…avascript race condition is fixed.
5c64df0
Commits on Feb 11, 2015
@moollaza moollaza Place error messages above mock results and ad 0db34d5
@moollaza moollaza Ensure we have a place to put mock results and ad
This occurs when parsing the DDG Homepage HTML
aaa2355
@moollaza moollaza Remove href from mock results and ad fb9aa8a
@moollaza moollaza update comments, simplify ad injection 2704f88
@moollaza moollaza Merge pull request #223 from duckduckgo/zach/goodie-templates-custom
Custom templates for Goodies
c24ff0f
@mintsoft mintsoft Merge pull request #219 from duckduckgo/zaahir/serp-add-content
Inject mock ad and results into SERP for realistic look
d0310ee
Commits on Feb 12, 2015
@moollaza moollaza Merge pull request #207 from gitter-badger/gitter-badge
Add a Gitter chat badge to README.md
b445ca0
Commits on Feb 17, 2015
@mikedep333 mikedep333 Update README.md to clarify which VM to download
A user made a mistake in issue #225 by downloading the VirtualBox VM for VMware. I think that by moving the URL closer to the section header, we can minimize the likelihood of that mistake.
c1f3ec9
@mikedep333 mikedep333 Update README.md: typo fix b69f3c3
@moollaza moollaza Merge pull request #228 from mikedep333/225-clarification
Update README.md to clarify which VM to download
5192ff5
Commits on Feb 19, 2015
@moollaza moollaza Refactor logic for checking share_dir, allow for subdirs in share_dir
Currently accessing files in a subdirectory of the share dir (e.g. /share/spice/currency/assets) does not work. This solves that problem.
This fix incurs a small performance cost thoguh because we now step through the list of all accessible share dirs in order to see
if the request path maps to an existing share dir. This is because the use of subdirs makes it harder to determine the Package name
from the request file path. For example how can we tell if /share/spice/currency/assets is DDG::Spice::Currency::Assets or a subdir
of the Spice::Currency share dir? The _share_dir_hash exists to provide the paths of all share dirs derived from package names which
gives us a way to determine the IA Package from the request path.

An alternate approach is to slowly remove elements from the request path until we find one which exists
in our _share_dir_hash, but we already iterate over the _path_hash so this follows convention.
021f3a2
@moollaza moollaza Better handling of requests to non-existant Spice rewrites b1b3426
@moollaza moollaza Fix indentation, switch to tabs, which we use throughout duckpan code
0aecfce
Commits on Feb 27, 2015
@moollaza moollaza Merge pull request #230 from duckduckgo/zaahir/allow-sharedir-subdirs
Allow grabbing assets from sharedir sub-directories
3b361a7
Commits on Mar 02, 2015
@SoerenWeber SoerenWeber Allow empty (self-closing) tags in answers. 75c246f
@moollaza moollaza Merge pull request #235 from SoerenWeber/bug-empty-tag
Allow empty (self-closing) tags in answers.
138b841
Commits on Mar 03, 2015
@moollaza moollaza better handling of UTF8 with default utf8 filehandling
70b90a3
Commits on Mar 04, 2015
@moollaza moollaza Remove use open from Server.pm, add to Query.pm 8456e1a
@moollaza moollaza remove unused Data::Printer from Server.pm
79e8a5e
Commits on Mar 11, 2015
@pfirsichbluete pfirsichbluete Make Web.pm find the correct share dir for IAs that are substring of …
…others

In duckduckgo/zeroclickinfo-spice the Time spice's name is a substring
of the Timer spice's name. When looking for resources for the Timer
IA, paths of the form

  .../timer/...

got mangled to

  .../time/r/...

because the matcher for IAs share directories did not check for the
trailing path separator. Hence, the share path of the Time (no trailing
“r” in Time) matched for Timer (trailing “r” in Timer) resources, and
path handling got confused.

By making the guard for identifying the relevant the share directory
also check on the trailing '/', the share directories of Time and
Timer are properly matched and the Timer IA again properly loads for
'timer 10 seconds'.

Fixes duckduckgo/zeroclickinfo-spice#1625
0819630
Commits on Mar 12, 2015
@moollaza moollaza Merge pull request #233 from duckduckgo/zaahir/utf8-fix
Proper handling of UTF-8 content in _print_msg
8cd1030
@moollaza moollaza Merge pull request #237 from pfirsichbluete/web-share-disambiguator
Make Web.pm find the correct share dir for IAs that are substring of oth...
7f2da61
Commits on Mar 18, 2015
@pfirsichbluete pfirsichbluete Die, if auto-templating for goodies with >=3 items is requested
Currently, auto-templating is only supported for up to 2 items.

This has been pointed out by @zachthompson in:
  duckduckgo/zeroclickinfo-goodies#1055 (comment)
9f6c618
Commits on Mar 20, 2015
@moollaza moollaza Merge pull request #240 from pfirsichbluete/goodie-auto-templating-in…
…put-limit

Die if auto-templating for goodies with >=3 items is requested
ef1fccc
Commits on Mar 23, 2015
@moollaza moollaza temporarily remove utf8 handling of filehandles, better fix coming soon
a6d27eb
@moollaza moollaza remove travisci dzil plugin, allow for faster container builds
8f5ae67
@moollaza moollaza Merge pull request #243 from duckduckgo/zaahir/temp-utf8-fix
temporarily remove utf8 handling of filehandles, better fix coming soon
51a3915
Commits on Mar 24, 2015
@moollaza moollaza remove unneeded rm command from .travis.yml
52c1586
@zachthompson zachthompson Merge pull request #244 from duckduckgo/zaahir/simplify-travis
remove travisci dzil plugin, allow for faster container builds
1b69688
Commits on Apr 03, 2015
@zachthompson zachthompson App::DuckPAN::DDG: Add a check for uppercase triggers; slight refactor
a1f85d6
@zachthompson zachthompson DDG: make the message a bit more explicit ea9f43a
Commits on Apr 06, 2015
@zachthompson zachthompson Limit check of uppercase to Words triggers
297fc7a
Commits on Apr 07, 2015
@moollaza moollaza Merge pull request #246 from duckduckgo/zach/warn-about-UC-triggers
Warn about uppercase triggers (issue #245)
47689f9
Commits on Apr 27, 2015
@zachthompson zachthompson dist.ini: remove CPAN::Repository 8168190
@zachthompson zachthompson dist.ini: autoprereqs...let's try 2cbf4c2
@zachthompson zachthompson .travis.yml: add mirrors
2347acf
Commits on Apr 28, 2015
@moollaza moollaza Merge pull request #249 from duckduckgo/zt/deps
Remove unneeded deps
6adf830
@moollaza moollaza AutoPrereqs, ignore DDG::* packages
c934e1a
@moollaza moollaza Merge pull request #251 from duckduckgo/zaahir/dist-ignore-ddg-packages
AutoPrereqs, ignore DDG::* packages
f830842
@moollaza moollaza Add notice about Node & Handlebars.js requirements
Also, small fix to Codio image position
741c760
Commits on May 07, 2015
@moollaza moollaza Add optional dependency section for Node, Handlebars, Uglify
4f0e3f1
@moollaza moollaza typo fix
e87d1d7
@moollaza moollaza Merge pull request #252 from duckduckgo/moollaza/dependency-update
Add notice about Node & Handlebars.js requirements
f9bdc8c
Commits on May 09, 2015
@moollaza moollaza DuckPAN Test: default to prove, add --build for dzil test
8469e24
Commits on May 14, 2015
@moollaza moollaza Fixed DuckPAN version checking and upgrade enforcement
c71aec7
@moollaza moollaza Change indentation to tabs, for consistency
ec34c17
@moollaza moollaza more indentation fixes
05e543f
@moollaza moollaza simplify checks for errors, fix indentation
a7f80d1
Commits on May 16, 2015
@moollaza moollaza Fixed naming collision in duckpan assets, use https
076de8e
Commits on May 18, 2015
@moollaza moollaza Add check and prompt for missing IA Bundles
df3c00c
@moollaza moollaza fix indentation
3ca46b1
@moollaza moollaza one more indent fix
ca538e1
@moollaza moollaza string interpolation for the win
49356db
@zachthompson zachthompson DuckPAN: install missing modules automatically ec24dad
@zachthompson zachthompson Merge branch 'zaahir/check-ia-bundles' of github.com:duckduckgo/p5-ap…
…p-duckpan into zaahir/check-ia-bundles

Conflicts:
	lib/App/DuckPAN.pm
de352c7
@moollaza moollaza Better message handling, let duckpan_install emit notices
481c24f
@moollaza moollaza Fix indentation
d4f8026
@moollaza moollaza Merge pull request #259 from duckduckgo/zaahir/check-ia-bundles
Add check and prompt for missing IA Bundles
5f22c4c
@moollaza moollaza resolve merge conflicts
596da3a
@moollaza moollaza remove unneeded escapes
0ed9799
@moollaza moollaza reorg variable declarations, small fixes
be2f8b9
Commits on May 19, 2015
@moollaza moollaza Merge pull request #256 from duckduckgo/zaahir/version-check-fix
Version check fix
0b6ec27
Commits on May 20, 2015
@zachthompson zachthompson Add metdata to the SERP
c52e242
Commits on May 21, 2015
@moollaza moollaza Merge pull request #260 from duckduckgo/zach/metadata
Add metdata to the SERP
d21110f
Commits on May 22, 2015
@zachthompson zachthompson Merge pull request #257 from duckduckgo/zaahir/fix-duckpan-filenames
Works for me.
079f5ca
Commits on May 25, 2015
@moollaza moollaza slight refactr, more succint code
09f96d8
Commits on May 26, 2015
@zachthompson zachthompson Merge pull request #254 from duckduckgo/zaahir/duckpan-test-update
Nice, thanks @moollaza.
4eebad3
@moollaza moollaza make sure we grab the new serp.css file
1bb968f
@moollaza moollaza Merge pull request #261 from duckduckgo/zaahir/grab-serp-css
make sure we grab the new serp.css file
6393af9
Commits on May 27, 2015
@moollaza moollaza make sure we grab new minified serp css file
a62fdaa
@moollaza moollaza Merge pull request #262 from duckduckgo/zaahir/serp-css
make sure we grab new minified serp css file
d704547
Commits on Jun 23, 2015
@zachthompson zachthompson Use alternate ddhX servers for API calls so devs aren't dead in the w…
…ater if ddh1 is down.

Some small efficiency improvements
fd439b4
@moollaza moollaza Merge pull request #264 from duckduckgo/zach/ddh1-10
Alternate ddhX servers for API calls
b70aa74