New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check $localver is defined in earlier if statement to prevent undef error #101

Merged
merged 1 commit into from Aug 1, 2014

Conversation

Projects
None yet
4 participants
@moollaza
Member

moollaza commented Aug 1, 2014

Currently, line 98 (https://github.com/duckduckgo/p5-app-duckpan/blob/master/lib/App/DuckPAN/Perl.pm#L98) assumes $localver is defined, I've moved the check for $localver in the next line to the preceeding line
//cc @russellholt @malbin

@malbin

This comment has been minimized.

Show comment
Hide comment
@malbin

malbin Aug 1, 2014

Just tested -- it works. Thanks for the quick reply--this was potentially annoying 👊

malbin commented Aug 1, 2014

Just tested -- it works. Thanks for the quick reply--this was potentially annoying 👊

print "$_: $localver installed, $pin_version pin, $duckpan_module_version latest\n";
if ($localver && $pin_version > $localver && $duckpan_module_version > $localver && $duckpan_module_version <= $pin_version) {
if ($pin_version > $localver && $duckpan_module_version > $localver && $duckpan_module_version <= $pin_version) {

This comment has been minimized.

@jagtalon

jagtalon Aug 1, 2014

Member

Cool! Please add a comment that explains what this line does.

@jagtalon

jagtalon Aug 1, 2014

Member

Cool! Please add a comment that explains what this line does.

This comment has been minimized.

@russellholt

russellholt Aug 1, 2014

Contributor

He didn't write it

@russellholt

russellholt Aug 1, 2014

Contributor

He didn't write it

@russellholt

This comment has been minimized.

Show comment
Hide comment
@russellholt

russellholt Aug 1, 2014

Contributor

Thanks, @moollaza 👍

Contributor

russellholt commented Aug 1, 2014

Thanks, @moollaza 👍

russellholt added a commit that referenced this pull request Aug 1, 2014

Merge pull request #101 from duckduckgo/zaahir/duckpan-fix
Check $localver is defined in earlier if statement to prevent undef error

@russellholt russellholt merged commit c6c16c2 into master Aug 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@russellholt russellholt deleted the zaahir/duckpan-fix branch Aug 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment