New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sharing #113

Merged
merged 2 commits into from Sep 4, 2014

Conversation

Projects
None yet
4 participants
@mwmiller
Contributor

mwmiller commented Sep 4, 2014

This is a step towards improving code sharing between Goodies and Spice. This mirrors up-coming changes in the DDG back-end to allow for the same CSS inclusion procedure on both.

This has been tested with a number of different styles of IAs in a variety of different states. There are no known ill effects from releasing this before the back-end changes are complete.

Also adds editor temporary files to .gitignore.

Also, I hate tabbed code.

mwmiller added some commits Sep 4, 2014

Web: share more code between Goodies and Spice
This needs some cleanup, but suffices for now to make the coming Goodies
CSS changes work as intended.
@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 4, 2014

Member

@mwmiller this is awesome, so excited to see this 👍


Tabs are the future.

Member

moollaza commented Sep 4, 2014

@mwmiller this is awesome, so excited to see this 👍


Tabs are the future.

@mwmiller

This comment has been minimized.

Show comment
Hide comment
@mwmiller

mwmiller Sep 4, 2014

Contributor

Tabs are the future.

I used to think you were cool, man. 💔

Contributor

mwmiller commented Sep 4, 2014

Tabs are the future.

I used to think you were cool, man. 💔

moollaza added a commit that referenced this pull request Sep 4, 2014

@moollaza moollaza merged commit 8769163 into duckduckgo:master Sep 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@mwmiller mwmiller deleted the mwmiller:code_sharing branch Sep 4, 2014

@mintsoft

This comment has been minimized.

Show comment
Hide comment
@mintsoft

mintsoft Sep 4, 2014

Member

Tabs are the future.

❤️ @moollaza you and me baby; we'll show them all!

Member

mintsoft commented Sep 4, 2014

Tabs are the future.

❤️ @moollaza you and me baby; we'll show them all!

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 4, 2014

Member

hahaha @mwmiller you were correct, I am totally cool 😎 , that's why I use tabs (you're definitely welcome to join the party btw).

@mintsoft -- hehe they don't know what they're missing.

Member

moollaza commented Sep 4, 2014

hahaha @mwmiller you were correct, I am totally cool 😎 , that's why I use tabs (you're definitely welcome to join the party btw).

@mintsoft -- hehe they don't know what they're missing.

@jagtalon

This comment has been minimized.

Show comment
Hide comment
@jagtalon

jagtalon Sep 12, 2014

Member

@moollaza @mintsoft we don't welcome tab lovers in these parts 😤

Member

jagtalon commented Sep 12, 2014

@moollaza @mintsoft we don't welcome tab lovers in these parts 😤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment