New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuckPAN: add 'reinstall' command. #114

Merged
merged 2 commits into from Sep 4, 2014

Conversation

Projects
None yet
2 participants
@mwmiller
Contributor

mwmiller commented Sep 4, 2014

This is probably a pretty niche need. If you are doing work on the DDG
or App::DuckPAN modules, you may have installed "newer versions" which
will not necessarily correlate to the version numbers as they will be
published eventually.

duckpan reinstall forces duckpan to install the latest version from
the public repostitory without regard to which versions are currently
installed locally.

@moollaza moollaza added the Improvement label Sep 4, 2014

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 4, 2014

Member

@mwmiller this is pretty neat, but I'm still a little unclear about the use case -- what problem does this solve?

Member

moollaza commented Sep 4, 2014

@mwmiller this is pretty neat, but I'm still a little unclear about the use case -- what problem does this solve?

@mwmiller

This comment has been minimized.

Show comment
Hide comment
@mwmiller

mwmiller Sep 4, 2014

Contributor

@moollaza Over the past couple of weeks I have made changes to the DDG and App::DuckPAN packages. For example, I did the CamelCase stuff in this repository. Once that was set, I wanted to run duckpan new in one of the IA repositories to make sure everything was working as expected. It doesn't hurt to make sure that it will actually install, too. So, I do dzil install in the p5-app-duckpan repository and get my shiny new version installed.

dzil install will note that the latest released version is 0.152, increment the version number and install my changes as 0.153. That's all well and good until: I never make my pull request or it gets rejected or someone else releases a new version ahead of my changes being integrated. Since I already have "0.153" installed, I can't 'upgrade' to the latest version.

One work around would be to check out the repository and dzil install from master. This is almost certainly the released version... but that's not guaranteed, either.

Enter duckpan reinstall. I can get my core installed packages into "the same state as everyone else" without regard to how much I have been mucking about with them.

Contributor

mwmiller commented Sep 4, 2014

@moollaza Over the past couple of weeks I have made changes to the DDG and App::DuckPAN packages. For example, I did the CamelCase stuff in this repository. Once that was set, I wanted to run duckpan new in one of the IA repositories to make sure everything was working as expected. It doesn't hurt to make sure that it will actually install, too. So, I do dzil install in the p5-app-duckpan repository and get my shiny new version installed.

dzil install will note that the latest released version is 0.152, increment the version number and install my changes as 0.153. That's all well and good until: I never make my pull request or it gets rejected or someone else releases a new version ahead of my changes being integrated. Since I already have "0.153" installed, I can't 'upgrade' to the latest version.

One work around would be to check out the repository and dzil install from master. This is almost certainly the released version... but that's not guaranteed, either.

Enter duckpan reinstall. I can get my core installed packages into "the same state as everyone else" without regard to how much I have been mucking about with them.

DuckPAN: add 'reinstall' command.
This is probably a pretty niche need.  If you are doing work on the DDG
or App::DuckPAN modules, you may have installed "newer versions" which
will not necessarily correlate to the version numbers as they will be
published eventually.

`duckpan reinstall` forces duckpan to install the latest version from
the public repostitory without regard to which versions are currently
installed locally.
@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 4, 2014

Member

ah, ok that makes sense, I've just always switched to master, pulled and installed. This LGTM 👍

Member

moollaza commented Sep 4, 2014

ah, ok that makes sense, I've just always switched to master, pulled and installed. This LGTM 👍

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 4, 2014

Member

@mwmiller actually please update the bin/duckpan to mention the new feature, and updating the README too wouldn't hurt ;)

Member

moollaza commented Sep 4, 2014

@mwmiller actually please update the bin/duckpan to mention the new feature, and updating the README too wouldn't hurt ;)

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 4, 2014

Member

or go ahead and merge this if you want to do that later/in another PR -- I'm good with this though.

Member

moollaza commented Sep 4, 2014

or go ahead and merge this if you want to do that later/in another PR -- I'm good with this though.

@mwmiller

This comment has been minimized.

Show comment
Hide comment
@mwmiller

mwmiller Sep 4, 2014

Contributor

Ok, I am pretty displeased with the output of bin/duckpan but I didn't pay much attention to whence it came. I'll make those changes and let you know.

Contributor

mwmiller commented Sep 4, 2014

Ok, I am pretty displeased with the output of bin/duckpan but I didn't pay much attention to whence it came. I'll make those changes and let you know.

@mwmiller

This comment has been minimized.

Show comment
Hide comment
@mwmiller

mwmiller Sep 4, 2014

Contributor

@moollaza I've added the documentation. I spent a little time trying to fix up the output, but it became clear I was heading down a rabbit hole. I'm going to leave that be for now.

Contributor

mwmiller commented Sep 4, 2014

@moollaza I've added the documentation. I spent a little time trying to fix up the output, but it became clear I was heading down a rabbit hole. I'm going to leave that be for now.

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 4, 2014

Member

LGTM 👍 Thanks @mwmiller !

Member

moollaza commented Sep 4, 2014

LGTM 👍 Thanks @mwmiller !

moollaza added a commit that referenced this pull request Sep 4, 2014

Merge pull request #114 from mwmiller/reinstall
DuckPAN: add 'reinstall' command.

@moollaza moollaza merged commit 6a99ec6 into duckduckgo:master Sep 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@mwmiller mwmiller deleted the mwmiller:reinstall branch Sep 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment