New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JSON Version, fixes #129 #135

Merged
merged 1 commit into from Oct 16, 2014

Conversation

Projects
None yet
1 participant
@moollaza
Member

moollaza commented Oct 16, 2014

Explained here that JSON needs to be bumped to allow the PromptIfStale tests to pass.

  • Could also add JSON::XS to the dist. There seems to be a discrepency between JSON < 2.9 and JSON::XS > 3 which was causing tests to fail.

cc// @mwmiller @jagtalon @tommytommytommy

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Oct 16, 2014

Member

Merging so I can release newest DuckPAN with changes from #133

Member

moollaza commented Oct 16, 2014

Merging so I can release newest DuckPAN with changes from #133

moollaza added a commit that referenced this pull request Oct 16, 2014

@moollaza moollaza merged commit 0a64367 into master Oct 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@moollaza moollaza deleted the zaahir/bump-json-version branch Oct 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment