New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IO::All and Path::Class with Path::Tiny. #145

Merged
merged 1 commit into from Oct 27, 2014

Conversation

Projects
None yet
2 participants
@mwmiller
Contributor

mwmiller commented Oct 24, 2014

This should make dealing with paths somewhat more straight-
forward and reusable.

I have tested correct operation (both happy and unhappy paths) for the following commands:

  • duckpan check
  • duckpan query
  • duckpan server
  • duckpan help
  • duckpan test
  • duckpan installdeps
  • duckpan reinstall

duckpan publisher fails with an apparently unrelated problem.

I did not manually verify the duckpan env bits because they are covered with tests.

Replace IO::All and Path::Class with Path::Tiny.
This should make dealing with paths somewhat more straight-
forward and reusable.
@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Oct 27, 2014

Member

LGTM 👍

Member

moollaza commented Oct 27, 2014

LGTM 👍

moollaza added a commit that referenced this pull request Oct 27, 2014

Merge pull request #145 from duckduckgo/mwm/tiny_paths_all_alike
Replace IO::All and Path::Class with Path::Tiny.

@moollaza moollaza merged commit 7788602 into master Oct 27, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@moollaza moollaza deleted the mwm/tiny_paths_all_alike branch Oct 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment