New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Die if auto-templating for goodies with >=3 items is requested #240

Merged
merged 1 commit into from Mar 20, 2015

Conversation

Projects
None yet
3 participants
@pfirsichbluete
Contributor

pfirsichbluete commented Mar 17, 2015

Currently, auto-templating is only supported for up to 2 items.

This has been pointed out by @zachthompson in:
duckduckgo/zeroclickinfo-goodies#1055 (comment)

Not sure if such a warning is over the top or not.
It'd certainly help while developing.

@pfirsichbluete pfirsichbluete referenced this pull request Mar 17, 2015

Merged

Gcd #1055

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Mar 18, 2015

Member

LGTM 👍

@zachthompson any thoughts?

Member

moollaza commented Mar 18, 2015

LGTM 👍

@zachthompson any thoughts?

@moollaza moollaza closed this Mar 18, 2015

@moollaza moollaza reopened this Mar 18, 2015

@zachthompson

This comment has been minimized.

Show comment
Hide comment
@zachthompson

zachthompson Mar 18, 2015

Contributor

@moollaza @pfirsichbluete What about just die'ing? The template won't be there so not much point in continuing.

Contributor

zachthompson commented Mar 18, 2015

@moollaza @pfirsichbluete What about just die'ing? The template won't be there so not much point in continuing.

Die, if auto-templating for goodies with >=3 items is requested
Currently, auto-templating is only supported for up to 2 items.

This has been pointed out by @zachthompson in:
  duckduckgo/zeroclickinfo-goodies#1055 (comment)
@pfirsichbluete

This comment has been minimized.

Show comment
Hide comment
@pfirsichbluete

pfirsichbluete Mar 18, 2015

Contributor

What about just die'ing?

Done in 9f6c618. PR updated.

Contributor

pfirsichbluete commented Mar 18, 2015

What about just die'ing?

Done in 9f6c618. PR updated.

@pfirsichbluete pfirsichbluete changed the title from Warn if auto-templating for goodies with >=3 items is requested to Die if auto-templating for goodies with >=3 items is requested Mar 19, 2015

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Mar 20, 2015

Member

LGTM 👍

Member

moollaza commented Mar 20, 2015

LGTM 👍

moollaza added a commit that referenced this pull request Mar 20, 2015

Merge pull request #240 from pfirsichbluete/goodie-auto-templating-in…
…put-limit

Die if auto-templating for goodies with >=3 items is requested

@moollaza moollaza merged commit ef1fccc into duckduckgo:master Mar 20, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pfirsichbluete pfirsichbluete deleted the pfirsichbluete:goodie-auto-templating-input-limit branch Mar 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment