New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuckPAN: No bundles by default #272

Merged
merged 6 commits into from Oct 5, 2015

Conversation

Projects
None yet
2 participants
@zachthompson
Contributor

zachthompson commented Oct 1, 2015

There is no requirement for IA bundles to be installed in the development environment. This removes them from being automatically considered during requirements checking and when upgrading/reinstalling/latest. They can still be installed and managed manually.

Also fixes a bug with the reinstall/latest commands.

zachthompson added some commits Oct 1, 2015

DuckPAN:
	* No bundles by default
	* Capture reinstall/latest!
Perl: skip repo versions, e.g. 9.999 and give notice
@@ -300,12 +300,12 @@ sub execute {
elsif($m eq 'ddg' && $ddg){ next }
push @modules, $_;
}
elsif (m/^duckpan|update|(upgrade|reinstall|latest)$/i) {
elsif (m/^duckpan|update|(upgrade|(reinstall|latest))$/i) {

This comment has been minimized.

@zachthompson

zachthompson Oct 1, 2015

Contributor

I'm debating whether we really want to support both update (only DuckPAN) and upgrade (DuckPAN + DDG) any longer. Wouldn't it make sense to do both with update and individually if specified on the command-line?

@zachthompson

zachthompson Oct 1, 2015

Contributor

I'm debating whether we really want to support both update (only DuckPAN) and upgrade (DuckPAN + DDG) any longer. Wouldn't it make sense to do both with update and individually if specified on the command-line?

This comment has been minimized.

@moollaza

moollaza Oct 5, 2015

Member

@zachthompson I've seen some CLI's that support both. upgrade could be used to upgrade installed packages and update would only update the DuckPAN client.

OSX's homebrew handles it the same way, whereas npm has an update <pkg> command.

@moollaza

moollaza Oct 5, 2015

Member

@zachthompson I've seen some CLI's that support both. upgrade could be used to upgrade installed packages and update would only update the DuckPAN client.

OSX's homebrew handles it the same way, whereas npm has an update <pkg> command.

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Oct 5, 2015

Member

@zachthompson this LGTM.

I realize that this has really been the only thing informing me that a new bundle was released. It's a separate issue, but I think we should still have something in place that notifies us (or at least me?) of new IA Bundle releases. Even an email would suffice I suppose.

Member

moollaza commented Oct 5, 2015

@zachthompson this LGTM.

I realize that this has really been the only thing informing me that a new bundle was released. It's a separate issue, but I think we should still have something in place that notifies us (or at least me?) of new IA Bundle releases. Even an email would suffice I suppose.

moollaza added a commit that referenced this pull request Oct 5, 2015

@moollaza moollaza merged commit d474025 into master Oct 5, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@moollaza moollaza deleted the zach/no-default-bundles branch Oct 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment