implement the 'test' command #3

Closed
wants to merge 4 commits into
from

Projects

None yet

3 participants

Member
ghedo commented Aug 2, 2012

Just a simple implementation of the test command, which uses Test::Harness (in perl core), and a few doc fixes.

It made me notice zeroclickinfo-spice #74, so I guess it works.

Contributor
Getty commented Aug 2, 2012

Nice! Good idea, the problem i see here is that we are generally using Dist::Zilla on the ground, so technical our tests must go through dzil test in this case here, cause else the distribution will not be build and the test runs on the "plain files", which is FINE for like all cases we have so far, but will probably make a problem at some point. Can we head into that direction more with it?

Member
ghedo commented Aug 2, 2012

The problem being that dzil is quite heavy and slow (and needs additional dependencies), so that yes, when releasing it is probably better to run dzil test --release or whatever, but it is uncomfortable for example when developing a new plugin, when you usually run the tests many times. Also, I was just thinking that the command may optionally run a single test e.g. duckpan test Twitter, this way the command would be more useful for the plugin developers.

So maybe a note in the documentation which says that this command is intended for development and not for releases would do?

Contributor
Getty commented Aug 2, 2012

Normally for the testing of the plugins we use the duckpan query/server feature so that you can test it in the complete environment, the testsuite should run in complete, i agree that it might be a bordercase interesting to just run one test, but then we could also teach the people how todo so (prove -Ilib t/....), that would make the understanding of the toolchain higher. Also: We use dzil with purpose, even tho its heavy we like it, its taking care of lots of stuff we do, so we would prefer if you think about extending dzil (like with a plugin) so that dzil test can do that and we then in duckpan use this feature.

Longtime I plan to make a dzil replacement which is lightweighted but achieves the most common tasks directly, but thats a long time in the future ;) or you wanna help me hehe.

Contributor
Getty commented Aug 2, 2012

P.S.: Best come to IRC to discuss this through ;) irc.freenode.net #duckduckgo

Member
ghedo commented Aug 2, 2012

Well, perl -I..., dzil and this are not mutually exclusive, one can choose what he prefers. Though if it's going to run dzil test, there's no point in having a separate command at all (dzil is also shorter) and should probably be removed from the documentation too (same goes for release maybe).

I just pushed the args thing plus colored output support just for future reference, but feel free to close this as you find appropriate.

Contributor
Getty commented Aug 2, 2012

We try to normalize to duckpan to make it longtime possible to abstract that away. Dont forget that we also get like python, java and co. packages, which we also handle inside that structure, so it could be that we make totally different procedures as dzil for them and might not add them to dzil at all. Then duckpan test/release can handle those extra problems. You really should join us on IRC ;).

Member
ghedo commented Aug 2, 2012

Sorry, I have not much time for IRC right now.

Owner
moollaza commented Oct 7, 2013

This PR is stale, closing for now. Can reopen if anyone wants to pick this up again.

@moollaza moollaza closed this Oct 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment