Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

KJV Bible plugin #21

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
2 participants

garyrh commented May 19, 2012

This plugin would supersede the spice "bible" plugin.

I tried to kill two bugs with one commit here: one was that the old plugin used an API that had so-so results, so I replaced it with a downloadable King James Version; second, someone requested abbreviations, so I took a stab at it.

I don't think I understood the docs too well, so any feedback is welcome.

Contributor

rpicard commented May 24, 2012

I'm working on testing this. I'll let you know if I run into any problems with the scripts.

Contributor

rpicard commented Jul 25, 2012

@mithrandiragain If you're still interested in working on this one I have a little feedback. Right now you create two records, "genesis #:#" and "gen #:#." It would be better to have the latter redirect to the former.

garyrh commented Jul 26, 2012

Okay, abbreviations now redirect to the full verse.

Contributor

rpicard commented Jul 26, 2012

@mithrandiragain The pieces aren't in the right place. You should look at how some of the other python parse scripts construct the string[1] so it's easier to see that the formatting is correct.

[1] https://github.com/duckduckgo/zeroclickinfo-fathead/blob/master/firefox_about_config/parse.py#L17

garyrh commented Jul 27, 2012

@rpicard Oops, sorry about that. Should be fixed now.

Contributor

rpicard commented Jul 28, 2012

I'm working on debugging some issues with this. I'm not really sure why it's not working yet.

Contributor

rpicard commented Oct 27, 2012

@mithrandiragain Okay, I finally figured out what was causing the problem with this. It was the colons in the title. You can see what it currently looks like here. I'll need to do some more work to get everything working with colons. That said, this result looks pretty good. It seems like it may be better to just modify the spice to accomplish the abbreviations. Could you give me some examples where this source is much better than the spice?

garyrh commented Oct 27, 2012

@rpicard Looks great! KJV seemed more standardized, so I thought whoever uses this would prefer that instead. I also thought that using fathead would be more reliable (weird TOS changes, downtime, etc.) Honestly, both look fine to me.

Contributor

rpicard commented Oct 27, 2012

Ah, it looks like colons actually do work! You just have to specify the trigger -- "bible" -- for now, so it overrides the spice. I'll see about getting rid of the spice.

https://robert.duckduckgo.com/?q=genesis+1%3A4+bible

Contributor

rpicard commented Oct 30, 2012

@mithrandiragain We're just about ready to deploy this. First though, would you mind adding in another redirect for gen/genesis # #, i.e. the numbers separated by spaces.

garyrh commented Oct 31, 2012

@rpicard That should do it!

Contributor

rpicard commented Nov 1, 2012

🚀 We have liftoff!

https://duckduckgo.com/?q=gen+1%3A2

Right now it's overridden by the spice, so this query doesn't trigger it, but the fix for that will be deployed momentarily.

What Twitter handle should I use for attribution?

garyrh commented Nov 1, 2012

@rpicard Yay! @mithrandiragain would be fine.

Contributor

rpicard commented Nov 1, 2012

Alrighty, that fix should be deployed soon. This pull request has been merged into the master branch. Thanks for working with me on this!

@rpicard rpicard closed this Nov 1, 2012

garyrh commented Nov 1, 2012

Thanks @rpicard!

Contributor

rpicard commented Nov 6, 2012

👍 No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment