Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Merge all package tracking IA's into 1, implement new design #1138

Closed
moollaza opened this issue May 19, 2015 · 7 comments
Closed

Merge all package tracking IA's into 1, implement new design #1138

moollaza opened this issue May 19, 2015 · 7 comments

Comments

@moollaza
Copy link
Member

Currently, we have several Package Tracking IA's, each of which is implemented as their own Perl Package. Really, none of these IA's really need to be on their own and should probably be merged so we can continue to add more carriers to the list.

We should be able to create a single "PackageTracking" Goodie which loads a data file that specifies the name, word triggers and regex pattern for their tracking codes. Using this, the Goodie should be able to create triggers and regexes that map to carriers.

In the case that only one carrier works, we can use the new Icon template to produce a result. If multiple providers are valid, we can use the list template to show the matching providers.

Anyone interested in tackling this?

New designs

Icon view:
trackpackage-logos-v1 1

(This is meant to demonstrate all the logos -- we'd only show one of these depending on the matched carrier)

List view:
trackpackage-list-v1 1x3

@abeyang
Copy link
Contributor

abeyang commented May 19, 2015

Here are the assets:

http://cl.ly/3q1y1x3P0f2V

@mintsoft
Copy link
Collaborator

If no-one else has picked this up in a few days I can take it on

@dronov
Copy link
Contributor

dronov commented May 23, 2015

I would like to fix this issue. So I'm going to make the PR as fast as I can.

@mintsoft
Copy link
Collaborator

@dronov Excellent! Any problems, just open a PR and someone'll swing in to lend a hand 👍

dronov added a commit to dronov/zeroclickinfo-goodies that referenced this issue May 26, 2015
Mailkov added a commit to Mailkov/zeroclickinfo-goodies that referenced this issue Nov 21, 2015
@Mailkov
Copy link
Contributor

Mailkov commented Dec 14, 2015

@abeyang @moollaza the icons on http://cl.ly/3q1y1x3P0f2V must contain background color because background colors of logos are different IMHO

@abeyang
Copy link
Contributor

abeyang commented Dec 17, 2015

@Mailkov not sure I understand what you mean. The background color in the mockups should be generated from html/css.

@Mailkov
Copy link
Contributor

Mailkov commented Dec 17, 2015

@abeyang This is the result when I use icons on http://cl.ly/3q1y1x3P0f2V (in this case BRT and DHL)
answerpackagetracking
As you can see the logos haven't the correct background color ... for BRT (bg color should be a shade of Red) an for DHL (bg color should be a shade of Yellow ).I don't want setting bg color by html/css because it's different for many logos and I don't know the exact color shade.
So the icons must contain bg color, IMHO.
I hope it's now more understandable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants