KirshApps's First Goodie #1015

kirshapps · 2015-02-20T23:57:34Z

What does your Instant Answer do?

It tells people that I am awesome, who would otherwise not know.

What problem does your Instant Answer solve (Why is it better than organic links)?

It tells the world that I am awesome.

What are some example queries that trigger this Instant Answer?

Example: "duckduckhack kirshapps"

Which communities will this Instant Answer be especially useful for? (gamers, book lovers, etc)

This Instant Answer is good for everyone.

Where did you hear about DuckDuckHack? (For first time contributors)

By clicking a link from the DuckDuckGo Search Engine.

What does the Instant Answer look like? (Provide a screenshot for new or updated Instant Answers)

Checklist

Please place an 'X' where appropriate.

- [X] Added metadata and attribution information (https://duck.co/duckduckhack/metadata)
- [X] Wrote test file and added to t/ directory (https://duck.co/duckduckhack/goodie_tests)
- [X] Verified that instant answer adheres to design guidelines (https://duck.co/duckduckhack/design_styleguide)
- [X] Verified that instant answer adheres to code styleguide (https://duck.co/duckduckhack/code_styleguide)
- [X] Tested cross-browser compatibility

    Please let us know which browsers/devices you've tested on:
    - Windows 8
        - [X] Google Chrome
        - [X] Firefox
        - [] Opera
        - [] IE 10

    - Windows 7
        - [] Google Chrome
        - [] Firefox
        - [] Opera
        - [] IE 8
        - [] IE 9
        - [] IE 10

    - Windows XP
        - [] IE 7
        - [] IE 8

    - Mac OSX
        - [X] Google Chrome
        - [X] Firefox
        - [] Opera
        - [] Safari

    - iOS (iPhone)
        - [] Safari Mobile
        - [] Google Chrome
        - [] Opera

    - iOS (iPad)
        - [] Safari Mobile
        - [] Google Chrome
        - [] Opera

    - Android
        - [] Firefox
        - [] Native Browser
        - [] Google Chrome
        - [] Opera

mintsoft · 2015-02-21T16:52:02Z

lib/DDG/Goodie/IsAwesome/kirshapps.pm

+topics "special_interest", "geek";
+code_url "https://github.com/duckduckgo/zeroclickinfo-goodies/blob/master/lib/DDG/Goodie/IsAwesome/kirshapps.pm";
+attribution github => ["https://github.com/kirshapps", "kirshapps"],
+            ;


these two lines should be one line like so:

attribution github => ["https://github.com/kirshapps", "kirshapps"];

javathunderman · 2015-02-22T00:29:22Z

t/IsAwesome/kirshapps.t

+    [qw(
+        DDG::Goodie::IsAwesome::kirshapps
+    )],
+    'duckduckhack kirshapps' => test_zci('kirshapps is awesome and has successfully completed the DuckDuckHack Goodie tutorial!'),


Can you decapitalize the g in goodie? This is what is making the tests fail.

@javathunderman Probably want to capitilise the "Goodie" in https://github.com/duckduckgo/zeroclickinfo-goodies/pull/1015/files#diff-6afa7237557aa8ba50464e27ce0e8155R16

Either makes sense...It's up to @kirshapps

@javathunderman Hate to be that guy..... 😬 As "Goodie" is a proper noun it does start with a capital letter and is included in the tutorial this way, but overall it's a tiny change and either way would work.. 😄

@MrChrisW You're right, and don't worry...More than usual I am that guy. 😄

kirshapps · 2015-02-24T18:41:29Z

Thanks @moollaza, I think I've got it now!

mintsoft · 2015-02-28T22:28:40Z

lib/DDG/Goodie/IsAwesome/kirshapps.pm

+triggers start => "duckduckhack kirshapps";
+handle remainder => sub {
+    return if $_;
+	return "kirshapps is awesome and has successfully completed the DuckDuckHack goodie tutorial!"


@kirshapps Can you fix this hard-tab here? It should be 4 spaces 👍

Hi @mintsoft. How exactly would I do that?

@kirshapps sorry for the slow reply; you could just delete the tab character and manually type 4 spaces; however the Codio editor should already be configured for spaces/"soft tabs":

Thanks @mintsoft.

KirshApps's First Goodie

mintsoft · 2015-03-04T08:13:04Z

Cool thanks @kirshapps Congrats on your first Goodie!

moollaza · 2015-03-11T00:10:58Z

@kirshapps congrats! It's live: https://duckduckgo.com/?q=duckduckhack+kirshapps&ia=answer

Thanks again for taking the time to contribute! We really appreciate it. Feel free to stick around and comment/help on other PR's & Issues or even submit more Instant Answers!

kirshapps added 2 commits February 20, 2015 23:40

My First Goodie

ff65f81

My First Goodie

4a137a9

MrChrisW added the First Goodie! label Feb 21, 2015

mintsoft reviewed Feb 21, 2015
View reviewed changes

Goodie Fix

457e271

javathunderman reviewed Feb 22, 2015
View reviewed changes

kirshapps added 2 commits February 22, 2015 18:54

Test File

c9e9522

Fix

b314871

mintsoft reviewed Feb 28, 2015
View reviewed changes

Tabs

6fca6e1

mintsoft added a commit that referenced this pull request Mar 4, 2015

Merge pull request #1015 from kirshapps/master

01fb8ca

KirshApps's First Goodie

mintsoft merged commit 01fb8ca into duckduckgo:master Mar 4, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KirshApps's First Goodie #1015

KirshApps's First Goodie #1015

kirshapps commented Feb 20, 2015

mintsoft Feb 21, 2015

javathunderman Feb 22, 2015

MrChrisW Feb 22, 2015

javathunderman Feb 22, 2015

MrChrisW Feb 22, 2015

javathunderman Feb 22, 2015

kirshapps commented Feb 24, 2015

mintsoft Feb 28, 2015

kirshapps Mar 2, 2015

mintsoft Mar 3, 2015

kirshapps Mar 4, 2015

mintsoft commented Mar 4, 2015

moollaza commented Mar 11, 2015

KirshApps's First Goodie #1015

KirshApps's First Goodie #1015

Conversation

kirshapps commented Feb 20, 2015

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kirshapps commented Feb 24, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mintsoft commented Mar 4, 2015

moollaza commented Mar 11, 2015