New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classic cocktails #1208

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@jppope
Contributor

jppope commented Jun 25, 2015

What does your Instant Answer do?

Provides a list of frequently used cocktails

What problem does your Instant Answer solve (Why is it better than organic links)?

it will make if quicker to get multiple drink recipes for classic cocktails especially considering the organic results that normally display always make you dig through a whole bunch of ads to find a 4 line drink recipe

What is the data source for your Instant Answer? (Provide a link if possible)

Various, but the notable one => http://www.iba-world.com/index.php?option=com_content&view=article&id=88
I'm going to develop the list of classic cocktails to be a mashup of the technical "classics" decided by the IBA and other governing bodies

Why did you choose this data source?

the IBA is a good list to start from. But generating a list of classic cocktails is an art form. I've spent a decent time studying this concept from the grand masters. The bartenders of locations such as: Little Branch (NYC), AttaBoy (NYC), Apotheke (NYC), Franklin Mortgage (Philly), 320 main (orange county), Felix (Hong Kong), Absynthe (San Francisco), the Ranstead Room (Philly), Milk and honey (NYC), Please don't tell (NYC). So between the recommendations of those folks and a large (30 book library) of cocktail books... I'm just trying to put together a decent list.

The starting list is mostly "classics" with a couple of variations early to keep the list friendly

Are there any other alternative (better) data sources?

not really.

What are some example queries that trigger this Instant Answer?

classic cocktails, cocktail recipes, manhattan recipe, How to make a margarita, etc

Which communities will this Instant Answer be especially useful for? (gamers, book lovers, etc)

Tech, foodies, and Cocktail junkies.

Is this Instant Answer connected to a DuckDuckHack Instant Answer idea?

no clue what that is

Which existing Instant Answers will this one supercede/overlap with?

nope.

Are you having any problems? Do you need our help with anything?

I'd like to break it down for instant answers that will give individual cocktails too

Where did you hear about DuckDuckHack? (For first time contributors)

meetup.com

What does the Instant Answer look like? (Provide a screenshot for new or updated Instant Answers)

thank you


IA Page: https://duck.co/ia/view/classic_cocktails_cheat_sheet

@MrChrisW

This comment has been minimized.

Show comment
Hide comment
@MrChrisW

MrChrisW Jun 25, 2015

Member

Hi @jppope , thanks for your contribution. Do you mind filling out the Goodie Pull Request Template and adding it to your initial comment. This will provide the community a quick way to review your CheatSheet Goodie. Thanks 👍

Member

MrChrisW commented Jun 25, 2015

Hi @jppope , thanks for your contribution. Do you mind filling out the Goodie Pull Request Template and adding it to your initial comment. This will provide the community a quick way to review your CheatSheet Goodie. Thanks 👍

Show outdated Hide outdated share/goodie/cheat_sheets/classic_cocktails.json
@@ -0,0 +1,157 @@
{
"id":"Classic_Cocktails",

This comment has been minimized.

@moollaza

moollaza Jun 25, 2015

Member

Please change to classic_cocktails_cheat_sheet

@moollaza

moollaza Jun 25, 2015

Member

Please change to classic_cocktails_cheat_sheet

Show outdated Hide outdated share/goodie/cheat_sheets/classic_cocktails.json
"sections":{
"Brown Liquor":[
{
"name":"Old Fashioned",

This comment has been minimized.

@moollaza

moollaza Jun 25, 2015

Member

Whoops, there's a specific syntax you need to use in order for this to work.

Please take a look at the example in the CheatSheet documentation: https://duck.co/duckduckhack/goodie_cheat_sheets

The sections are made up of key-value pairs, which are used to build the UI you see here: https://duckduckgo.com/?q=tmux+cheat+sheet&ia=cheatsheet

@moollaza

moollaza Jun 25, 2015

Member

Whoops, there's a specific syntax you need to use in order for this to work.

Please take a look at the example in the CheatSheet documentation: https://duck.co/duckduckhack/goodie_cheat_sheets

The sections are made up of key-value pairs, which are used to build the UI you see here: https://duckduckgo.com/?q=tmux+cheat+sheet&ia=cheatsheet

@jppope

This comment has been minimized.

Show comment
Hide comment
@jppope

jppope Jun 25, 2015

Contributor

Sorry about the syntax errors early ... didn't realize that it wouldn't just take pure json. I plan on expanding this list but I just wanted to get a base file started. Let me know if you need anything else. and one last note... "Unicorn Blood" is more of an underground classic between the best bartenders... it isn't classic in the "ubiquitous" sense that the rest are but its very much a classic in the sense that real bartenders know it and drink it, so i thought I would add it.

Contributor

jppope commented Jun 25, 2015

Sorry about the syntax errors early ... didn't realize that it wouldn't just take pure json. I plan on expanding this list but I just wanted to get a base file started. Let me know if you need anything else. and one last note... "Unicorn Blood" is more of an underground classic between the best bartenders... it isn't classic in the "ubiquitous" sense that the rest are but its very much a classic in the sense that real bartenders know it and drink it, so i thought I would add it.

@jppope

This comment has been minimized.

Show comment
Hide comment
@jppope

jppope Jul 6, 2015

Contributor

Just following up on this... I was really hoping to see it pop up :) how do we know about its inclusion?

Contributor

jppope commented Jul 6, 2015

Just following up on this... I was really hoping to see it pop up :) how do we know about its inclusion?

@@ -0,0 +1,144 @@
{
"id":"Classic_Cocktails_cheat_sheet",

This comment has been minimized.

@zachthompson

zachthompson Aug 19, 2015

Contributor

All lower-case.

@zachthompson

zachthompson Aug 19, 2015

Contributor

All lower-case.

"sections":{
"Brown Liquor":[
{
"Old Fashioned",

This comment has been minimized.

@zachthompson

zachthompson Aug 19, 2015

Contributor

"key":

@zachthompson

zachthompson Aug 19, 2015

Contributor

"key":

"Brown Liquor":[
{
"Old Fashioned",
"Value":[

This comment has been minimized.

@zachthompson

zachthompson Aug 19, 2015

Contributor

All "Value" keys need to be "val".

@zachthompson

zachthompson Aug 19, 2015

Contributor

All "Value" keys need to be "val".

],
"Howard Hughes Style":[
{
"Key":"Unicorn Blood",

This comment has been minimized.

@zachthompson

zachthompson Aug 19, 2015

Contributor

Lower-case "k"

@zachthompson

zachthompson Aug 19, 2015

Contributor

Lower-case "k"

},
{
"key":"Manhattan",
"Value":[

This comment has been minimized.

@zachthompson

zachthompson Aug 19, 2015

Contributor

Unfortunately we don't support displaying array items on separate lines. So this won't look as expected.

@zachthompson

zachthompson Aug 19, 2015

Contributor

Unfortunately we don't support displaying array items on separate lines. So this won't look as expected.

@zachthompson

This comment has been minimized.

Show comment
Hide comment
@zachthompson

zachthompson Aug 19, 2015

Contributor

After making all of the changes I mentioned in the line notes, this is what it will look like:

classic-cocktails

Without supporting newlines, I'm not sure this can work.

@jppope The file needs to be named classic-cocktails.json with a hypen instead of an underscore as well.

Contributor

zachthompson commented Aug 19, 2015

After making all of the changes I mentioned in the line notes, this is what it will look like:

classic-cocktails

Without supporting newlines, I'm not sure this can work.

@jppope The file needs to be named classic-cocktails.json with a hypen instead of an underscore as well.

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Aug 19, 2015

Member

@jppope sorry about the delay on this one! It somehow slipped past me! Really sorry.

My colleague @zachthompson has left some feedback outlining the changes that need to be made.

You'll be able to verify that the JSON actually works by testing your cheat sheet with DuckPAN. Whatever you see there is how it will look when it get's merged and is released live. We don't support arrays for the val and don't currently allow newline characters either. I think we'll have to opt for a comma-separate list for each val.

Also, we've now launched support for "templates" so if you add "template_type": "reference" this Cheat Sheet will look even more awesome!

Member

moollaza commented Aug 19, 2015

@jppope sorry about the delay on this one! It somehow slipped past me! Really sorry.

My colleague @zachthompson has left some feedback outlining the changes that need to be made.

You'll be able to verify that the JSON actually works by testing your cheat sheet with DuckPAN. Whatever you see there is how it will look when it get's merged and is released live. We don't support arrays for the val and don't currently allow newline characters either. I think we'll have to opt for a comma-separate list for each val.

Also, we've now launched support for "templates" so if you add "template_type": "reference" this Cheat Sheet will look even more awesome!

@moollaza moollaza self-assigned this Aug 19, 2015

"id":"Classic_Cocktails_cheat_sheet",
"key":"Classic Cocktails",
"description":"The Top Classic Cocktails",
"metadata":{

This comment has been minimized.

@moollaza

moollaza Aug 19, 2015

Member

Let's add in the template specification here: "template_type": "reference",

@moollaza

moollaza Aug 19, 2015

Member

Let's add in the template specification here: "template_type": "reference",

@Razzeee

This comment has been minimized.

Show comment
Hide comment
@Razzeee

Razzeee Sep 4, 2015

This may also be nice as a spice, if you use http://www.thecocktaildb.com/

Razzeee commented Sep 4, 2015

This may also be nice as a spice, if you use http://www.thecocktaildb.com/

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 17, 2015

Member

This may also be nice as a spice, if you use http://www.thecocktaildb.com/

@Razzeee thanks a lot for that link! We had a Spice until very recently that allowed us to search for drink making instructions, but the website suddenly went offline without notice. We'd love to replace the source and bring the IA back online. Would you be interested in doing it?

Member

moollaza commented Sep 17, 2015

This may also be nice as a spice, if you use http://www.thecocktaildb.com/

@Razzeee thanks a lot for that link! We had a Spice until very recently that allowed us to search for drink making instructions, but the website suddenly went offline without notice. We'd love to replace the source and bring the IA back online. Would you be interested in doing it?

@Razzeee

This comment has been minimized.

Show comment
Hide comment
@Razzeee

Razzeee Sep 17, 2015

@moollaza
I'm afraid I don't have the time required for that. As I would have to learn your technology stack fist and theres currently no time in my life for that. Sorry.

Razzeee commented Sep 17, 2015

@moollaza
I'm afraid I don't have the time required for that. As I would have to learn your technology stack fist and theres currently no time in my life for that. Sorry.

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 17, 2015

Member

I'm afraid I don't have the time required for that. As I would have to learn your technology stack fist and >theres currently no time in my life for that. Sorry.

@Razzeee that's no problem, I'll create a task for the community to tackle this. Thanks again for sharing the API!

Member

moollaza commented Sep 17, 2015

I'm afraid I don't have the time required for that. As I would have to learn your technology stack fist and >theres currently no time in my life for that. Sorry.

@Razzeee that's no problem, I'll create a task for the community to tackle this. Thanks again for sharing the API!

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 17, 2015

Member

@Razzeee FYI : duckduckgo/zeroclickinfo-spice#2184 -- Would you mind sharing this on the Kodi forum?

Member

moollaza commented Sep 17, 2015

@Razzeee FYI : duckduckgo/zeroclickinfo-spice#2184 -- Would you mind sharing this on the Kodi forum?

@Razzeee

This comment has been minimized.

Show comment
Hide comment
@Razzeee

Razzeee commented Sep 17, 2015

Will do

@daxtheduck daxtheduck deployed to beta.duckduckgo.com Sep 25, 2015 Active

@daxtheduck daxtheduck deployed to beta.duckduckgo.com Sep 29, 2015 Active

@daxtheduck daxtheduck deployed to beta.duckduckgo.com Sep 29, 2015 Active

@moollaza

This comment has been minimized.

Show comment
Hide comment
@moollaza

moollaza Sep 29, 2015

Member

@jppope Ping! I'm just checking in to see if you're still interested in finishing this one up? We'd love to see this go live!

There's absolutely no rush, just wanted to make sure you're not stuck on anything.

For now I'll close this. If you want to pick it up again, we'll be sure to open it up for you.

Member

moollaza commented Sep 29, 2015

@jppope Ping! I'm just checking in to see if you're still interested in finishing this one up? We'd love to see this go live!

There's absolutely no rush, just wanted to make sure you're not stuck on anything.

For now I'll close this. If you want to pick it up again, we'll be sure to open it up for you.

@moollaza moollaza closed this Sep 29, 2015

@jppope

This comment has been minimized.

Show comment
Hide comment
@jppope

jppope Sep 29, 2015

Contributor

Whoa...

Sorry... I thought we were good...

what all do I / did I need to do to get it live?

My apologies about the confusion, I thought when you were making those
changes that you were making them yourself and that I didn't have to go
back in and fix them.

On Tue, Sep 29, 2015 at 9:59 AM, Zaahir Moolla notifications@github.com
wrote:

@jppope https://github.com/jppope Ping! I'm just checking in to see if
you're still interested in finishing this one up? We'd love to see this go
live!

There's absolutely no rush, just wanted to make sure you're not stuck on
anything.

For now I'll close this. If you want to pick it up again, we'll be sure to
open it up for you.


Reply to this email directly or view it on GitHub
#1208 (comment)
.

Contributor

jppope commented Sep 29, 2015

Whoa...

Sorry... I thought we were good...

what all do I / did I need to do to get it live?

My apologies about the confusion, I thought when you were making those
changes that you were making them yourself and that I didn't have to go
back in and fix them.

On Tue, Sep 29, 2015 at 9:59 AM, Zaahir Moolla notifications@github.com
wrote:

@jppope https://github.com/jppope Ping! I'm just checking in to see if
you're still interested in finishing this one up? We'd love to see this go
live!

There's absolutely no rush, just wanted to make sure you're not stuck on
anything.

For now I'll close this. If you want to pick it up again, we'll be sure to
open it up for you.


Reply to this email directly or view it on GitHub
#1208 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment